Lwjgl3 restart input handle - #1268
Conversation
|
Anything needed for this? Clarifications, better coding..? :) |
|
As far as I'm concerned, all this needs is a reviewer, someone (other than you) who understands LWJGL. |
MeFisto94
left a comment
MeFisto94
left a comment
There was a problem hiding this comment.
Basically looks good, a few small things to adjust here and there, let's see.
Hint for all: Use the "Split View" and not the unified view, that way it's better to see where the code moved from and to.
| } | ||
| initCallbacks(); | ||
|
|
||
| initialized = true; |
There was a problem hiding this comment.
This isn't resetted when resetting the context.
Do you know about the special purpose of it?
Like I wonder if we should reset this value, like when initCallback fails and thus initialized is false after a restart.
There was a problem hiding this comment.
I use the flag to see if I need to re-create the callbacks. I'm unsure what the flag otherwise symbolizes, it was there already.
| if (listener != null) { | ||
| sendFirstMouseEvent(); | ||
| } | ||
|
|
||
| setCursorVisible(cursorVisible); | ||
| logger.fine("Mouse created."); | ||
| initialized = true; |
There was a problem hiding this comment.
This isn't needed when restarting?
I mean setCursorVisible probably isn't, as for that you don't have to restart the context.
What about sendFirstMouseEvent?
The initialized question from above also applies here.
There was a problem hiding this comment.
I guess this all just mimics LWJGL 2. It doesn't seem to send either after restart.
|
|
||
| // Create OpenCL | ||
| if (settings.isOpenCLSupport()) { | ||
| initOpenCL(window); | ||
| } |
There was a problem hiding this comment.
Any specific reason why this should now only happen when restarting and not as part of the general init process? Wouldn't this prevent openCL init when regularly starting?
There was a problem hiding this comment.
It is part of the general init process. This is called in createContext which in turn is used by the restart and the initial context.
|
|
||
| destroyContext(); | ||
| super.internalDestroy(); | ||
| glfwTerminate(); |
There was a problem hiding this comment.
I just wonder here if we can't/shouldn't arrange it that the restart could call deinitInThread() and initInThread instead of manually re-creating the context.
I think all that would be required is moving the glfwTerminate post deinitInThread, right?
I don't know if that works by the API.
There was a problem hiding this comment.
Well, I tried it just now. Seems to actually fix #1013 . But also causes some side effects. Cursor is somehow gone as well as some other elements and all inputs... Need to investigate this a bit more...
* Reinit inputs on context restart * Added test issue from issue #1013 * Verify that the inputs are already initialized
3 participants
Fixes the input issue mentioned in issue #1013 . It of course happens on LWJGL3 universally. Not a Nifty thing.
The inputs are very much tied to the window context.