Fixes Bullet-Native Artifacts not containing natives when not building from cpp source and not using the build target. - #1255
Merged
Conversation
…g from cpp source and not using the build target.
Member
Author
|
Note: there is still a flaw in this build: the -sources jar also contains the built natives ALONG with the native sources. |
Member
Mhh, can you open an issue for that? |
Member
Author
|
I've taken the freedom to self-merge this, given that the review was positive and that it's urgent as the SDK and the jme tests needed this commit to work :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we need to depend on the assemble target, as build only happens when the project is additionally tested, which it might be for CI, but not when including as a subproject (like the SDK did) and also not when calling
gradlew run, which one would do when executing the jme tests.I've taken the freedom to run an auto formatter on that snippet as well to fix whitespaces, I hope you don't mind. It just looked like minified js to me ;)