Fixes #1251 - Support OpenGL3.1 on LWJGL2 and LWJGL3 - #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same rules apply here: No answer after 7 days, I'll merge it.
Do note that JOGL has it's own Renderer and thus this AppSettings does not affect it (which is something I'd love to address).
Also the VR backend only supports two specific versions, be it because of specific requirements or because of not having the code written dynamically for this, so this remains untouched.
Also please watch the AppSettings file itself and not the diff: I've dragged LWJGL_OPENGL3 above OPENGL30 and then added 31 as a copy, thus it looks like changing OPENGL3 to 31.