Android buffer allocator implementation - #1214
Merged
Merged
Conversation
Resync fork
Update fork
…lasses to be used instead of the default ReflectionAllocator
Member
|
Thanks :) |
Member
|
After merging PR #1147 which changes OGLESContext.java (https://github.com/jMonkeyEngine/jmonkeyengine/pull/1147/files#diff-51f8ab703009d20f32b7588036e3fb27) I was expecting GitHub shows conflicts with the base branch for this PR but it does not! |
Contributor
Author
|
Changes to OGLESContext in this PR are between lines 62 and 84 which were not modified by the gl3 PR, so there's no conflict and can be merged safely. But if you feel more comfortable updating this branch to master previously to merge tell me and I'll do ;) |
Member
|
Ok, now that it is safe, then I guess no need to update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new buffer allocator created to solve ReflectionAllocator exceptions while freeing memory (destroyDirectBuffer method) caused by new buffer wrapper classes (java.nio.ByteBufferAs[type]Buffer) in android and improving memory management not having to wait for GC to free direct memory if desired.
Related forum post: https://hub.jmonkeyengine.org/t/exception-when-destroying-direct-memory-in-android/42483