Add support for fog in materials. - #1094
Merged
2 commits merged intoMay 30, 2019
Merged
Conversation
ghost
requested a review
from Nehon
May 24, 2019 09:36
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per thread: https://hub.jmonkeyengine.org/t/add-fog-to-lighting-j3md/41873/6
I have added fog to multi-pass lighting.j3md/lighting.vert/lighting.frag for consideration.
I have not made any changes to SPLighting.vert/.frag or PBRLighting yet because the implementation would be the same, so once this has been approved, it can be ported to the rest of the materials.
I have also included a TestLightingFog in the jme-examples to test the three available fog-modes.
The user sets the parameter "UseFog" to enable fog, and must set a FogColor.
Setting one of the following settings will enable that fog type. This is how you decide which fog-type to use.
All of this is described in code in the TestLightingFog class.
https://github.com/jayfella/jmonkeyengine/blob/master/jme3-examples/src/main/java/jme3test/light/TestLightingFog.java