Added an easy way to add sub steps to the profiler - #1067
Merged
Conversation
…pp State Manager to profile the update method of each app state
Contributor
|
Neat. The path manipulation weirded me out at first but then I noticed the whole class is smelly in that regard. So good job navigating that! For the record: my notes on the smelliness that have nothing to do with this patch:
|
Contributor
Author
|
Yea, the whole path implementation was a little weird but it works for how simple the profiler is. It worked for me with spoxel and really helped narrow down some of the performance problems I had hidden in my code. I added a missing file change to the commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the implementation I use in spoxel to dig into performance within app states. The default profiler only gives timings for the App State Manager, but this code automatically profiles each of the app states added to the App State Manager. You can set further breakpoints within the update methods of an app state by calling:
profiler.appSubStep("EffectState", "Run Client Effects");In this case "EffectState" is an app state and "Run Client Effects" is one of the profiling points i've set.