Skip to content

Fix argument order in call to join().#357

Merged
treffynnon merged 2 commits intoj4mie:developfrom
CatalinFrancu:patch-1
Apr 28, 2020
Merged

Fix argument order in call to join().#357
treffynnon merged 2 commits intoj4mie:developfrom
CatalinFrancu:patch-1

Conversation

@CatalinFrancu
Copy link
Copy Markdown
Contributor

@CatalinFrancu CatalinFrancu commented Dec 11, 2019

No description provided.

@szepeviktor
Copy link
Copy Markdown

szepeviktor commented Jan 29, 2020 •
edited
Loading

Included in #351

@henryruhs
Copy link
Copy Markdown

henryruhs commented Apr 25, 2020 •
edited
Loading

@szepeviktor I closed that PR - seems to be too much changes for the maintainer
@j4mie Please merge that PR and release bugfix - thanks

@treffynnon
Copy link
Copy Markdown
Collaborator

treffynnon commented Apr 25, 2020

@redaxmedia I am unclear what you want to have merged here

@henryruhs
Copy link
Copy Markdown

henryruhs commented Apr 25, 2020 •
edited
Loading

@treffynnon This pull request?

It removes one deprecation warning by switching glue and array. Using PHPUnit with convertWarningsToExceptions="true" failes under PHP 7.4 otherwise.

@treffynnon treffynnon changed the base branch from master to develop April 28, 2020 20:49
@treffynnon treffynnon merged commit bacd47d into j4mie:develop Apr 28, 2020
@treffynnon
Copy link
Copy Markdown
Collaborator

treffynnon commented Apr 29, 2020 •
edited
Loading

Thank you @CatalinFrancu and @redaxmedia I have now merged the pull request and tagged release 1.5.7.

@redaxmedia I have also slightly updated the readme to further clarify the feature complete message.

Feature [/API] complete

Idiorm is now considered to be feature complete as of version 1.5.0. Whilst it will continue to be maintained with bug fixes there will be no further new features added from this point on. [This means that if a pull request makes breaking changes to the API or requires anything other than a patch version bump of the library then it will not be merged.]

Please do not submit feature requests [or API breaking changes] as they will be closed without ceremony.

@CatalinFrancu CatalinFrancu deleted the patch-1 branch April 29, 2020 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CatalinFrancu @szepeviktor @henryruhs @treffynnon