Fix autoincremented compound keys inserts#235
Merged
treffynnon merged 1 commit intoj4mie:developfrom Dec 14, 2016
Merged
Conversation
When inserting new records on a autoincremented compound keys table, a bug would prevent updating the autoincremented value. Fixes j4mie#233
Contributor
Author
|
Simon, I think this PR will fix the issue #233. I'm still waiting for @chihlongliu reply, but local tests seem to work. I'd advice to merge it into develop anyway. Thanks! |
|
Apologies for the delayed reply - I did test the patch and it does work for my application. Thanks, I really appreciate it! Best, Sent from my iPhone
|
Contributor
Author
|
Nice to hear that! Now let's hope it gets merged soon. |
voku
pushed a commit
to voku/idiorm
that referenced
this pull request
Dec 3, 2015
Collaborator
|
Thank you! |
Repository owner
locked and limited conversation to collaborators
Dec 14, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inserting new records on a autoincremented compound keys table, a
bug would prevent updating the autoincremented value.
Fixes #233