Custom cache functions by peter-mw · Pull Request #216 · j4mie/idiorm

peter-mw · 2014-06-20T12:44:27Z

As of #212

peter-mw · 2014-06-20T12:51:31Z

Cant understand why the build fails. Have no reason to do so, can you see?

peter-mw · 2014-06-20T12:52:10Z

Ok will fix indent issues

treffynnon · 2014-06-20T12:53:09Z

Looks like the build is failing with this error: https://travis-ci.org/j4mie/idiorm/jobs/28039970#L54

PHP Fatal error: Using $this when not in object context in /home/travis/build/j4mie/idiorm/test/CacheTest.php on line 43

peter-mw · 2014-06-20T12:55:13Z

Got it, thanks for your time helping out.

peter-mw · 2014-06-20T14:08:26Z

Hi Simon, the cache is not automatically deleted on save and this test never runs

https://github.com/peter-mw/idiorm/blob/master/test/CacheTest.php#L60

I want to make the cache to be deleted automatically on save. What do you think?

treffynnon · 2014-06-20T14:12:16Z

Well, that would change existing behaviour so that has the potential to
break backwards compatibility unless it were configurable and disabled by
default.

On 20 June 2014 15:08, Peter Ivanov [email protected] wrote:

Hi Simon, the cache is not automatically deleted on save and this test
never runs

https://github.com/peter-mw/idiorm/blob/master/test/CacheTest.php#L60

I want to make the cache to be deleted automatically on save. What do you
think?

—
Reply to this email directly or view it on GitHub
#216 (comment).

Simon Holywell
simonholywell.com
http://www.simonholywell.com/?utm_source=Email%20Signature&utm_medium=Email&utm_campaign=Email%20Signature
functionalphp.com
http://www.functionalphp.com/?utm_source=Email%20Signature&utm_medium=Email&utm_campaign=Email%20Signature
twitter.com/treffynnon
github.com/treffynnon

I have also written a book: Functional Programming in PHP
http://www.functionalphp.com/?utm_source=Email%20Signature&utm_medium=Email&utm_campaign=Email%20Signature

peter-mw · 2014-06-20T14:58:47Z

Added the option and readme.

It says the build is still failing, but i don't know why?

What i am doing wrong on line 47? I don't see https://github.com/peter-mw/idiorm/blob/master/test/CacheTest.php#L47

treffynnon · 2014-06-20T15:03:02Z

What is the error message you're getting back?

On 20 June 2014 15:58, Peter Ivanov [email protected] wrote:

Added the option and readme.

It says the build is still failing, but i don't know why?

What i am doing wrong on line 47? I don't see
https://github.com/peter-mw/idiorm/blob/master/test/CacheTest.php#L47

—
Reply to this email directly or view it on GitHub
#216 (comment).

Simon Holywell
simonholywell.com
http://www.simonholywell.com/?utm_source=Email%20Signature&utm_medium=Email&utm_campaign=Email%20Signature
functionalphp.com
http://www.functionalphp.com/?utm_source=Email%20Signature&utm_medium=Email&utm_campaign=Email%20Signature
twitter.com/treffynnon
github.com/treffynnon

I have also written a book: Functional Programming in PHP
http://www.functionalphp.com/?utm_source=Email%20Signature&utm_medium=Email&utm_campaign=Email%20Signature

peter-mw · 2014-06-20T15:05:05Z

Strange one.

Parse error: syntax error, unexpected T_FUNCTION in /home/travis/build/j4mie/idiorm/test/CacheTest.php on line 47

It works on my end and tests are passing

treffynnon · 2014-06-20T15:09:22Z

That is from a PHP 5.2 build - anonymous functions weren't supported back
then so please make your tests only run in later PHP versions by changing
the test class file name from *Test.php to *Test53.php just the like Config
tests have.

On 20 June 2014 16:05, Peter Ivanov [email protected] wrote:

Strange one.

Parse error: syntax error, unexpected T_FUNCTION in
/home/travis/build/j4mie/idiorm/test/CacheTest.php on line 47

—
Reply to this email directly or view it on GitHub
#216 (comment).

Simon Holywell
simonholywell.com
http://www.simonholywell.com/?utm_source=Email%20Signature&utm_medium=Email&utm_campaign=Email%20Signature
functionalphp.com
http://www.functionalphp.com/?utm_source=Email%20Signature&utm_medium=Email&utm_campaign=Email%20Signature
twitter.com/treffynnon
github.com/treffynnon

I have also written a book: Functional Programming in PHP
http://www.functionalphp.com/?utm_source=Email%20Signature&utm_medium=Email&utm_campaign=Email%20Signature

peter-mw · 2014-06-20T15:36:05Z

I think its ready. Can you take a look

peter-mw · 2014-06-20T15:48:30Z

Yeah fixed the spaces :)

Thanks for the guidelines, the implementation was not hard at all.

Hope this is OK to get merged at some time, so i can base my other work on it.

peter-mw · 2014-06-20T16:09:25Z

Done

peter-mw · 2014-06-20T16:18:43Z

Wait i need to override the create_cache_key function too, will add it now

`table_name` is more important than `connection_name`

peter-mw · 2014-06-20T19:48:58Z

Think its OK now.

I will try to implement the cache in the real app.

Will test properly and update this issue if i find any bugs

ghost · 2014-06-21T00:30:42Z

In the config docs

Idiorm's cache in never cleared by default

should be

Idiorm's cache is never cleared by default

Also, should this be merged into develop first?

treffynnon · 2014-06-21T07:03:31Z

Yes, this will be merged into the develop branch first. I can do this even
if the pull request is against master - it's just more difficult.

peter-mw · 2014-06-21T11:37:14Z

Hi, i can send PR in the develop branch, just the develop version was not working , that's why i pulled master

treffynnon · 2014-06-22T00:26:44Z

Merged in commit e7b77ad

peter-mw · 2014-06-22T11:30:14Z

YoHoo! Thanks for the release :)

peter-mw added 3 commits June 20, 2014 15:19

added cache callback #212

67caba4

added test

f1d16b0

Added text for custom cache

bb81397

peter-mw added 2 commits June 20, 2014 17:02

formating and tests

781e6e4

Merge branch 'master' of github.com:peter-mw/idiorm

7835a3f

added caching_auto_clear option

94b4355

peter-mw added 3 commits June 20, 2014 18:18

moved custom cache test for php 5.3+

e1cf053

fixed ConfigTest.php

1a4b9cc

tabs to spaces

d7f018b

peter-mw added 2 commits June 20, 2014 18:49

formating

680c9e8

formating

df0bde9

peter-mw added 5 commits June 20, 2014 19:34

added create_cache_key callback option

b1bc143

added $table_name to clear cache function

47ca00b

added $table_name to _create_cache_key

1064b66

added missing params

563bbdd

added $table_name to cache_query_result

3e85d0f

peter-mw added 4 commits June 20, 2014 22:11

formating

ae9fd3d

tabs

36964bc

added $table_name to check_query_cache

867aa33

unify cache parameters order

b080ffc

`table_name` is more important than `connection_name`

formating

8c8ed74

treffynnon closed this Jun 22, 2014

peter-mw mentioned this pull request Nov 18, 2014

Table prefix #247

Closed

Conversation

peter-mw commented Jun 20, 2014

Uh oh!

peter-mw commented Jun 20, 2014

Uh oh!

peter-mw commented Jun 20, 2014

Uh oh!

treffynnon commented Jun 20, 2014

Uh oh!

peter-mw commented Jun 20, 2014

Uh oh!

peter-mw commented Jun 20, 2014

Uh oh!

treffynnon commented Jun 20, 2014

Uh oh!

peter-mw commented Jun 20, 2014

Uh oh!

treffynnon commented Jun 20, 2014

Uh oh!

peter-mw commented Jun 20, 2014

Uh oh!

treffynnon commented Jun 20, 2014

Uh oh!

peter-mw commented Jun 20, 2014

Uh oh!

peter-mw commented Jun 20, 2014

Uh oh!

peter-mw commented Jun 20, 2014

Uh oh!

peter-mw commented Jun 20, 2014

Uh oh!

peter-mw commented Jun 20, 2014

Uh oh!

ghost commented Jun 21, 2014

Uh oh!

treffynnon commented Jun 21, 2014

Uh oh!

peter-mw commented Jun 21, 2014

Uh oh!

treffynnon commented Jun 22, 2014

Uh oh!

peter-mw commented Jun 22, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants