Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1974 +/- ##
==========================================
+ Coverage 92.18% 92.23% +0.04%
==========================================
Files 116 116
Lines 23287 23338 +51
==========================================
+ Hits 21468 21525 +57
+ Misses 1819 1813 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Rust toolchain resolution to prefer stable toolchains over newer beta/nightly ones when selecting from installed/system candidates, addressing the “system Rust uses nightly by default” behavior.
Changes:
- Add
RustVersion::channel()accessor to expose the detected toolchain channel (stable/beta/nightly). - Prefer stable/unnamed toolchains over beta and nightly when sorting installed/system toolchain candidates.
- Record the resolved toolchain channel in
InstallInfoforRustRequest::Any, and add unit tests covering the new selection order.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/prek/src/languages/rust/version.rs | Exposes the parsed toolchain channel via a new accessor on RustVersion. |
| crates/prek/src/languages/rust/rust.rs | Stores the resolved toolchain channel for RustRequest::Any based on the selected toolchain. |
| crates/prek/src/languages/rust/installer.rs | Introduces deterministic toolchain sorting that prefers stable over beta/nightly; adds unit tests for the new behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer stable Rust toolchains over newer nightly toolchains when resolving system Rust for default requests. Nightly is still used when it is the only matching candidate.
Closes #1970