Clarify why check-illegal-windows-names stays builtin-only#1857
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1857 +/- ##
==========================================
+ Coverage 92.14% 92.17% +0.03%
==========================================
Files 108 108
Lines 21750 21750
==========================================
+ Hits 20041 20048 +7
+ Misses 1709 1702 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies, in-code, why check-illegal-windows-names is implemented as a builtin hook (rather than as a pre_commit_hooks fast-path hook), given that upstream expresses it as a generic fail hook plus a files regex and prek already supports language: fail in Rust.
Changes:
- Added a module-level comment explaining why this hook remains in
builtin_hooksinstead ofpre_commit_hooks. - Clarified that the builtin implementation primarily reuses the regex for matching and emits a simple fail-style message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.