Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1622 +/- ##
==========================================
- Coverage 91.73% 91.73% -0.01%
==========================================
Files 96 96
Lines 18630 18642 +12
==========================================
+ Hits 17091 17102 +11
- Misses 1539 1540 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates prek uninstall behavior to clean up leftover *.legacy hook scripts that were created/managed by prek, preventing stale legacy hook files from lingering in .git/hooks.
Changes:
- Extend uninstall logic to detect and remove legacy hook files (
<hook>.legacy) when they matchprek’s managed script signature. - Adjust user-facing uninstall output when restoring a legacy hook back into place.
- Add an integration test covering removal of
prek-managed legacy hooks while preserving/restoring non-preklegacy scripts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/prek/src/cli/install.rs | Updates uninstall flow to remove prek-managed legacy hooks and refines restore messaging. |
| crates/prek/tests/install.rs | Updates uninstall snapshots and adds coverage for legacy-hook cleanup behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1621