Conversation
a1083ff to
fb0998f
Compare
|
Maybe you can separate the code improvement ( |
|
I can separate them out but then CI will not pass. It should still be feasible to review commit by commit. |
|
Or I can move the ci commit to the new PR too. |
9b33a51 to
d7a7e9b
Compare
|
Removed the ci part for now. Still need to replace |
|
I got nerd sniped quite hard by this but I had this on to-do list for few other projects. Now running |
j0k3r
left a comment
There was a problem hiding this comment.
I don't get everything about Rector (never used it).
What I understand if I add a new functional test is I'll need to run it once and then the fixture html will be generated and I'll need to update the functional test to use the fixture.
Am I right ?
If so, how do you catch headers you added in the test file?
|
Rector is a tool for automated code transformation. The transformation rule runs Graby and extract headers using |
|
If you check out the PR, you can try it yourself by removing the last commit and running |
f5fab22 to
d4bffa8
Compare
|
Can you rebase against the master? |
Currently only supports mocking single fetches.
|
Good job @jtojnar 👊 |
Use
composer rector(orcomposer rector -- --dry-run) to run the automated refactoring.