Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the login issue created by recent changes made by Google in OAuth Flow.
It is not longer possible to use
urn:ietf:wg:oauth:2.0:oobas redirect url and redirect to a page to copy auth-code.DriveStream/app/src/main/java/zechs/drive/stream/utils/util/Constants.kt
Line 15 in 5bc57ae
The new changes requires apps to create a local server and listen on a local port and catch authorization code, which is possible on android but not very ideal in my opinion (maybe in future), so for the time being we just ask users for the entire auth-url and extract the auth-code ourselves fixing the login problem.
Closes #63