zsh: allow to eval zsh completion#159
Merged
casperdcl merged 4 commits intoiterative:mainfrom Jan 31, 2024
Merged
Conversation
Allow to run `eval "$(my-prog --print-completion zsh)"` to enable completion in the current zsh environment. This change is inspired by pypa/pip#12173 and pallets/click#2544.
casperdcl
added
enhancement
casperdcl
requested changes
Jan 31, 2024
Collaborator
casperdcl
left a comment
casperdcl
left a comment
There was a problem hiding this comment.
Thanks! Do you want to update the failing tests too?
Contributor
Author
Done. The tests run successful at my machine with Python 3.11 now. |
casperdcl
reviewed
Jan 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage 88.88% 88.88%
=======================================
Files 3 3
Lines 360 360
=======================================
Hits 320 320
Misses 40 40 ☔ View full report in Codecov by Sentry. |
casperdcl
approved these changes
Jan 31, 2024
Contributor
Author
|
@casperdcl would it be possible to include this change in a new release? |
Collaborator
|
/tag v1.7.0 3b3ed28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to run
eval "$(my-prog --print-completion zsh)"to enable completion in the current zsh environment.This change is inspired by pypa/pip#12173 and pallets/click#2544.