Skip to content

Comments

Remove custom GH_TOKEN#151

Merged
casperdcl merged 2 commits intomainfrom
0x2b3bfa0-patch-1
Sep 20, 2023
Merged

Remove custom GH_TOKEN#151
casperdcl merged 2 commits intomainfrom
0x2b3bfa0-patch-1

Conversation

@0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Sep 13, 2023

Should work as well, right?

@0x2b3bfa0 0x2b3bfa0 added the enhancement New feature or request label Sep 13, 2023
@0x2b3bfa0 0x2b3bfa0 requested a review from casperdcl September 13, 2023 23:41
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to pypi September 13, 2023 23:41 — with GitHub Actions Inactive
@0x2b3bfa0 0x2b3bfa0 self-assigned this Sep 13, 2023
@codecov-commenter
Copy link

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@0x2b3bfa0 0x2b3bfa0 changed the title Remve custom GH_TOKEN Remove custom GH_TOKEN Sep 20, 2023
Copy link
Collaborator

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but I kinda prefer the bot showing up as the releaser

image

@iterative-olivaw
Copy link
Collaborator

But @0x2b3bfa0 will have to rotate my fine-grained personal access tokens every year.

@casperdcl casperdcl temporarily deployed to pypi September 20, 2023 21:23 — with GitHub Actions Inactive
@casperdcl casperdcl temporarily deployed to pypi September 20, 2023 21:25 — with GitHub Actions Inactive
Copy link
Collaborator

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be thee :happiny:

@0x2b3bfa0
Copy link
Member Author

:staryu:

@casperdcl casperdcl merged commit cde6e00 into main Sep 20, 2023
@casperdcl casperdcl deleted the 0x2b3bfa0-patch-1 branch September 20, 2023 21:29
@casperdcl casperdcl added technical-debt Refactoring, linting & tidying and removed enhancement New feature or request labels Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical-debt Refactoring, linting & tidying

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants