bash nounset mode fixes#143
Merged
casperdcl merged 1 commit intoiterative:mainfrom Jul 28, 2023
scop:fix/bash-nounset
Merged
Conversation
Fixes issues I came across while briefly testing the shtab completions of `keyring` in `set -o nounset` mode, as well tests failing in that mode. This might not be a complete set, but it's a start.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
=======================================
Coverage 88.88% 88.88%
=======================================
Files 3 3
Lines 360 360
=======================================
Hits 320 320
Misses 40 40
☔ View full report in Codecov by Sentry. |
casperdcl
added
external-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues I came across while briefly testing the shtab completions of
keyringinset -o nounsetmode, as well tests failing in that mode.This might not be a complete set, but it's a start.