Skip to content

Comments

Fix #89#114

Merged
casperdcl merged 4 commits intoiterative:mainfrom
Freed-Wu:iss89
Apr 2, 2023
Merged

Fix #89#114
casperdcl merged 4 commits intoiterative:mainfrom
Freed-Wu:iss89

Conversation

@Freed-Wu
Copy link
Contributor

No description provided.

@sourcery-ai

This comment was marked as off-topic.

@casperdcl casperdcl self-requested a review October 29, 2022 14:55
@casperdcl casperdcl added enhancement New feature or request good-first-issue Good for newcomers (good-first-issue) technical-debt Refactoring, linting & tidying external-request You asked, we did labels Oct 29, 2022
@Freed-Wu
Copy link
Contributor Author

Any other problem?

@Freed-Wu
Copy link
Contributor Author

@casperdcl ?

@casperdcl
Copy link
Collaborator

casperdcl commented Mar 30, 2023

Apologies for the delay; thanks for bumping, @Freed-Wu.

Added some tests.

Slightly concerned people may get confused (e.g. an FAQ might be "why does shtab --print-completion=bash mylib.get_parser print shtab's rather than mylib's completions?").

To help combat this, perhaps it's better to rename the option to --print-own-completion?

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.39%. Comparing base (1eb80f6) to head (40413bb).
⚠️ Report is 105 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   91.36%   91.39%   +0.02%     
==========================================
  Files           3        3              
  Lines         336      337       +1     
==========================================
+ Hits          307      308       +1     
  Misses         29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Freed-Wu
Copy link
Contributor Author

perhaps it's better to rename the option to --print-own-completion?

both are OK 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request external-request You asked, we did good-first-issue Good for newcomers (good-first-issue) technical-debt Refactoring, linting & tidying

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants