Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Comments

Update check-test-release.yml#493

Merged
aguschin merged 1 commit intomainfrom
fix/update-release-wf
Nov 21, 2022
Merged

Update check-test-release.yml#493
aguschin merged 1 commit intomainfrom
fix/update-release-wf

Conversation

@mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Nov 19, 2022

To be honest I just brainlessly copy-pasted iterative/shtab#121, @casperdcl did I succeed? 😄

@mike0sv mike0sv requested a review from a team November 19, 2022 14:34
@mike0sv mike0sv temporarily deployed to internal November 19, 2022 14:34 Inactive
@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Base: 60.01% // Head: 87.00% // Increases project coverage by +26.98% 🎉

Coverage data is based on head (64e268c) compared to base (6b511fd).
Patch coverage: 91.85% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #493       +/-   ##
===========================================
+ Coverage   60.01%   87.00%   +26.98%     
===========================================
  Files          95       96        +1     
  Lines        8135     8255      +120     
===========================================
+ Hits         4882     7182     +2300     
+ Misses       3253     1073     -2180     
Impacted Files Coverage Δ
mlem/cli/main.py 84.58% <ø> (+27.66%) ⬆️
mlem/contrib/catboost.py 98.33% <ø> (+43.10%) ⬆️
mlem/contrib/tensorflow.py 96.33% <ø> (+42.69%) ⬆️
mlem/core/import_objects.py 98.07% <ø> (+26.92%) ⬆️
mlem/core/model.py 94.59% <ø> (+21.62%) ⬆️
mlem/contrib/sklearn.py 80.43% <66.66%> (+23.08%) ⬆️
mlem/runtime/server.py 85.29% <78.57%> (-5.19%) ⬇️
mlem/runtime/interface.py 84.61% <84.61%> (+28.36%) ⬆️
mlem/api/commands.py 86.61% <100.00%> (+53.01%) ⬆️
mlem/cli/apply.py 96.15% <100.00%> (+38.46%) ⬆️
... and 86 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aguschin aguschin mentioned this pull request Nov 21, 2022
@aguschin
Copy link
Contributor

Since we need to make a release, I'll go ahead and merge this. No other way to check it'll work I guess :)

@aguschin aguschin merged commit 75e2074 into main Nov 21, 2022
@aguschin aguschin deleted the fix/update-release-wf branch November 21, 2022 06:38
@aguschin
Copy link
Contributor

Confirmed: successfully works! https://github.com/iterative/mlem/actions/runs/3512101417

Comment on lines 153 to 154
echo ::set-output name=tag::${GITHUB_REF#refs/tags/}
git log --pretty='format:%d%n- %s%n%b---' $(git tag --sort=v:refname | tail -n2 | head -n1)..HEAD > _CHANGES.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you no longer need these lines (i.e. can delete the name: Changelog step)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What that step was for in the first place? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was to extract the changelog from git commits (to help draft release notes).

It used to be in a separate (bash) step because the old way used an action (https://github.com/softprops/action-gh-release) rather than plain bash.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants