Conversation
Codecov ReportBase: 60.01% // Head: 87.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
===========================================
+ Coverage 60.01% 87.00% +26.98%
===========================================
Files 95 96 +1
Lines 8135 8255 +120
===========================================
+ Hits 4882 7182 +2300
+ Misses 3253 1073 -2180
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Since we need to make a release, I'll go ahead and merge this. No other way to check it'll work I guess :) |
|
Confirmed: successfully works! https://github.com/iterative/mlem/actions/runs/3512101417 |
| echo ::set-output name=tag::${GITHUB_REF#refs/tags/} | ||
| git log --pretty='format:%d%n- %s%n%b---' $(git tag --sort=v:refname | tail -n2 | head -n1)..HEAD > _CHANGES.md |
There was a problem hiding this comment.
I believe you no longer need these lines (i.e. can delete the name: Changelog step)
There was a problem hiding this comment.
What that step was for in the first place? :)
There was a problem hiding this comment.
it was to extract the changelog from git commits (to help draft release notes).
It used to be in a separate (bash) step because the old way used an action (https://github.com/softprops/action-gh-release) rather than plain bash.
To be honest I just brainlessly copy-pasted iterative/shtab#121, @casperdcl did I succeed? 😄