Skip to content

Fix crash for negative uvcUnit integers (Issue #42) #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
itaybre merged 1 commit into from
Apr 29, 2022
Merged

Fix crash for negative uvcUnit integers (Issue #42) #57

itaybre merged 1 commit into from
Apr 29, 2022

Conversation

@jazzychad
Copy link
Contributor

@jazzychad jazzychad commented Apr 28, 2022

Adds two guard statements in relevant methods in UVCControl.swift so
that casting a negative uvcUnit Int to UInt16 no longer crashes the
app.

@jazzychad
Fix crash for negative uvcUnit integers (Issue itaybre#42)
edb2d4f 
Adds two guard statements in relevant methods in UVCControl.swift so
that casting a negative `uvcUnit` Int to UInt16 no longer crashes the
app.
@jazzychad jazzychad mentioned this pull request Apr 28, 2022
Closed
itaybre
itaybre approved these changes Apr 29, 2022
View reviewed changes
Copy link
Owner

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding the issue

@itaybre itaybre merged commit 021ec45 into itaybre:master Apr 29, 2022
@itaybre itaybre added this to the 1.4.0 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itaybre itaybre itaybre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jazzychad @itaybre