Skip to content

Define exit_on_failure? to suppress thor's warning#344

Merged
unasuke merged 1 commit intomasterfrom
thor_warn
Dec 31, 2021
Merged

Define exit_on_failure? to suppress thor's warning#344
unasuke merged 1 commit intomasterfrom
thor_warn

Conversation

@unasuke
Copy link
Copy Markdown
Member

@unasuke unasuke commented Dec 31, 2021

fix #342

see it → rails/thor#651

unasuke
unasuke commented Dec 31, 2021
View reviewed changes
bin/itamae

require 'itamae/cli'
Itamae::CLI.start

Copy link
Copy Markdown
Member Author

@unasuke unasuke Dec 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic change 💄

@unasuke unasuke requested a review from sue445 December 31, 2021 15:05
sue445
sue445 approved these changes Dec 31, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@sue445 sue445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lib/itamae/cli.rb
end

def self.exit_on_failure?
true
Copy link
Copy Markdown
Member

@sue445 sue445 Dec 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also agree with this behavior

@unasuke unasuke merged commit 33d6d9a into master Dec 31, 2021
@unasuke unasuke deleted the thor_warn branch December 31, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sue445 sue445 sue445 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Thor Deprecation warning

2 participants

@unasuke @sue445