Fix logging in mixer_fault_test by dmitri-d · Pull Request #2141 · istio/proxy

dmitri-d · 2019-03-06T21:09:55Z

…with cli '-l' option

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

* Improve performance by removing MD5 for check cache keys Signed-off-by: Wayne Zhang <[email protected]> * not to allocate memory from stack Signed-off-by: Wayne Zhang <[email protected]> * Make debug string readable Signed-off-by: Wayne Zhang <[email protected]>

Signed-off-by: Lizan Zhou <[email protected]>

Signed-off-by: Wayne Zhang <[email protected]>

* Add a new TCP cluster rewrite filter This commit adds a new TCP cluster rewrite filter which allows users to rewrite TCP cluster names obtained via TLS SNI by matching via regex configuration. Signed-off-by: Venil Noronha <[email protected]> * Make TCP cluster rewrite stackable on SNI filter This commit updates the TCP Cluster Rewrite filter to be stackable on the SNI Cluster filter. Signed-off-by: Venil Noronha <[email protected]>

This commit updates the TCP Cluster Rewrite filter name to envoy.filters.network.tcp_cluster_rewrite. Signed-off-by: Venil Noronha <[email protected]>

This commit enables the static registration of the TCP Cluster Rewrite filter by updating the build configuration. Signed-off-by: Venil Noronha <[email protected]>

Envoy /server_info API was inconsistent intermittently causing errors on a Proxy update on Istio. This update will bring in the API fix to Istio. Signed-off-by: Venil Noronha <[email protected]>

* Update Envoy SHA Signed-off-by: JimmyCYJ <[email protected]> * Fix format. Signed-off-by: JimmyCYJ <[email protected]>

Merge release-1.1 to master

To use --distdir option of Bazel (which allows to use previously fetched tarballs instead of downloading dependencies during build), all dependencies should use http instead of git and need to have sha256 sums specified. Signed-off-by: Michal Rostecki <[email protected]>

Pull request #2002 removed signature calculation which was using BoringSSL as a dependency. BoringSSL is not needed anymore. Signed-off-by: Michal Rostecki <[email protected]>

* Update Envoy SHA to fcc68f1 Signed-off-by: JimmyCYJ <[email protected]> * Update SHA256 Signed-off-by: JimmyCYJ <[email protected]>

* update envoy SHA to 48b161e * use Http::AsyncClient::RequestOptions() in AsyncClient::send() * PerConnectionCluster::Key -> PerConnectionCluster::key() * use Http::AsyncClient::RequestOptions() in AsyncClient::send() in the test * fix format

* initial implementation of forward_downstream_api filter * fix the license message in BUILD (sh comments) * add missing dependencies * add definition of config_lib to BUILD * remove public visibility from forward_downstream_sni_lib * remove envoy_cc_binary dependency * StreamInfo::UpstreamServerName -> Network::UpstreamServerName * fix namespace (Extensions -> Tcp) * remove config_test

Signed-off-by: Shriram Rajagopalan <[email protected]>

Merge release-1.1 into master

* Removes dangling pointer in capture list of lambda function. (#2080) * Replace this with members in capture list. * update * fix format * Use shared_ptr to protect members which are passed to capture list of lambda function. (#2083) * fix bug * introduce ControlData * fix format * update * fix format * Revise * Pass ControlDataSharedPtr into Control and hold ref * pass JwtAuthenticationConstSharedPtr into JwtAuthStore to hold ref * Revise * Update Envoy SHA to latest with protobuf.Any configs (release-1.1). (#2082) * Update Envoy SHA to latest with protobuf.Any configs (release-1.1). For istio/istio#10993. Signed-off-by: Piotr Sikora <[email protected]> * review: don't open /dev/stdout in tests. Signed-off-by: Piotr Sikora <[email protected]> * Update Istio API to latest (1.1 branch) (#2084) Signed-off-by: Yangmin Zhu <[email protected]>

Merge release-1.1 master

* Update Envoy SHA to latest with protobuf.Any configs. For istio/istio#10993. Signed-off-by: Piotr Sikora <[email protected]> * review: don't open /dev/stdout in tests. Signed-off-by: Piotr Sikora <[email protected]>

Signed-off-by: Piotr Sikora <[email protected]>

sha256sum shouldn't be necessary, since we use gsha256sum on macOS. Signed-off-by: Piotr Sikora <[email protected]>

…1987)

kyessenov · 2019-03-06T21:12:30Z

Seems reasonable.
/lgtm
/approve

istio-testing · 2019-03-06T21:12:32Z

@kyessenov: changing LGTM is restricted to assignees, and assigning you to the PR failed.

Details

In response to this:

Seems reasonable.
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dmitri-d · 2019-03-06T21:13:00Z

@duderino: you may have fixed this in your copy already.

Explicit log-level in tests was resetting cli option I was passing to bazel via test_arg:

bazel  test -c opt --test_arg="-l trace" //test/integration:mixer_fault_test

* update envoy with latest build fixes Signed-off-by: Lizan Zhou <[email protected]> * update protobuf to match envoy Signed-off-by: Lizan Zhou <[email protected]> * timeSystem -> timeSource Signed-off-by: Lizan Zhou <[email protected]>

I have 39 commits in this repo.

Signed-off-by: Lizan Zhou <[email protected]>

duderino · 2019-03-12T17:58:32Z

/lgtm thanks for the PR. I'll merge post 1.1

istio-testing · 2019-03-12T17:58:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmitri-d, duderino, kyessenov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [duderino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…merge

Signed-off-by: Lizan Zhou <[email protected]>

merge release-1.1 to master

venilnoronha

Could you also fix the other test?

https://github.com/istio/proxy/blob/release-1.1/test/integration/int_client_server_test.cc#L318

…with cli '-l' option

istio-testing · 2019-03-20T18:35:25Z

@dmitri-d: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

googlebot · 2019-03-20T18:36:27Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

istio-testing · 2019-03-20T18:37:00Z

@dmitri-d: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
prow/proxy-presubmit.sh	`772b892`	link	`/test proxy-presubmit`
prow/proxy-presubmit-asan.sh	`772b892`	link	`/test proxy-presubmit-asan`
prow/proxy-presubmit-tsan.sh	`772b892`	link	`/test proxy-presubmit-tsan`

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dmitri-d · 2019-03-20T18:38:10Z

Opened a PR with these changes against master branch, closing this one.

qiwzhang and others added 30 commits October 26, 2018 16:01

alts: remove ALTS (#2003)

426eea9

Signed-off-by: Lizan Zhou <[email protected]>

Use std::hash for check cache. (#2009)

40d927a

Signed-off-by: Wayne Zhang <[email protected]>

Remove tests to compare signature values (#2015)

c63371b

Signed-off-by: Wayne Zhang <[email protected]>

update sample envoy config to latest version (#2016)

b0631da

Update TCP Cluster Rewrite filter name (#2019)

3e77b66

This commit updates the TCP Cluster Rewrite filter name to envoy.filters.network.tcp_cluster_rewrite. Signed-off-by: Venil Noronha <[email protected]>

Enable TCP Cluster Rewrite filter registration (#2021)

a93b785

This commit enables the static registration of the TCP Cluster Rewrite filter by updating the build configuration. Signed-off-by: Venil Noronha <[email protected]>

Update Envoy SHA to 4ef8562 (#2023)

67a0375

Envoy /server_info API was inconsistent intermittently causing errors on a Proxy update on Istio. This update will bring in the API fix to Istio. Signed-off-by: Venil Noronha <[email protected]>

add proxy postsubmit periodic (#2025)

32e134a

Update Envoy SHA to c41fa71 (#2029)

87737b8

* Update Envoy SHA Signed-off-by: JimmyCYJ <[email protected]> * Fix format. Signed-off-by: JimmyCYJ <[email protected]>

Merge remote-tracking branch 'origin/release-1.1' into r11tom

ba0f2c7

Merge pull request #2032 from rshriram/r11tom

4cfa354

Merge release-1.1 to master

bazel: Remove BoringSSL repository (#2035)

381c609

Pull request #2002 removed signature calculation which was using BoringSSL as a dependency. BoringSSL is not needed anymore. Signed-off-by: Michal Rostecki <[email protected]>

Update Envoy SHA to fcc68f1 (#2037)

255ac3c

* Update Envoy SHA to fcc68f1 Signed-off-by: JimmyCYJ <[email protected]> * Update SHA256 Signed-off-by: JimmyCYJ <[email protected]>

update envoy SHA to 48b161e (#2041)

f5a3fe4

* update envoy SHA to 48b161e * use Http::AsyncClient::RequestOptions() in AsyncClient::send() * PerConnectionCluster::Key -> PerConnectionCluster::key() * use Http::AsyncClient::RequestOptions() in AsyncClient::send() in the test * fix format

Add Venil to OWNERS (#2065)

df311cd

Signed-off-by: Shriram Rajagopalan <[email protected]>

Clarify log messages (#2066)

acd6df2

make build work with bazel 0.20 (#2068)

7c28b86

Merge release-1.1 into master

0a708eb

Merge pull request #2078 from hklai/1.1-master

e4adcdf

Merge release-1.1 into master

Merge remote-tracking branch 'upstream/release-1.1' into 1.1-master

545d6e9

Merge pull request #2086 from hklai/1.1-master

05a1534

Merge release-1.1 master

Update Envoy SHA to latest with protobuf.Any configs. (#2081)

eafb657

* Update Envoy SHA to latest with protobuf.Any configs. For istio/istio#10993. Signed-off-by: Piotr Sikora <[email protected]> * review: don't open /dev/stdout in tests. Signed-off-by: Piotr Sikora <[email protected]>

Run buildifier on the build files and add it to "make check". (#2088)

54d5807

Signed-off-by: Piotr Sikora <[email protected]>

Fix build on macOS. (#2090)

301a2eb

sha256sum shouldn't be necessary, since we use gsha256sum on macOS. Signed-off-by: Piotr Sikora <[email protected]>

[typo-fix] typo of the variable use_count -> wrote use_cound instead (#…

3f77bf0

…1987)

Add more checks for CORS preflight requests (#2140)

c676cae

googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 6, 2019

istio-testing requested review from lizan and rshriram March 6, 2019 21:09

lizan and others added 3 commits March 8, 2019 06:32

update envoy with latest build fixes (#2147)

77fcb35

* update envoy with latest build fixes Signed-off-by: Lizan Zhou <[email protected]> * update protobuf to match envoy Signed-off-by: Lizan Zhou <[email protected]> * timeSystem -> timeSource Signed-off-by: Lizan Zhou <[email protected]>

requesting to add myself as a reviewer/approver (#2148)

ef62615

I have 39 commits in this repo.

update envoy to pick up TLS logging for HTTP upstream (#2149)

7b6125d

Signed-off-by: Lizan Zhou <[email protected]>

istio-testing added the approved label Mar 12, 2019

lizan and others added 5 commits March 12, 2019 23:35

Merge remote-tracking branch 'upstream/release-1.1' into release-1.1_…

d86401d

…merge

fix build

4db5030

Signed-off-by: Lizan Zhou <[email protected]>

fix format

15924b9

Signed-off-by: Lizan Zhou <[email protected]>

fix status match

8a78e03

Signed-off-by: Lizan Zhou <[email protected]>

Merge pull request #2152 from lizan/release-1.1_merge

ecbd173

merge release-1.1 to master

dmitri-d mentioned this pull request Mar 20, 2019

Removed explicit log-level setting from tests, as it was interfering … #2155

Merged

Fixes environment-dependent failures in MixerFaultTest (#2156)

f263174

venilnoronha suggested changes Mar 20, 2019

View reviewed changes

Removed explicit log-level setting from tests, as it was interfering …

772b892

…with cli '-l' option

istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 20, 2019

googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Mar 20, 2019

dmitri-d closed this Mar 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix logging in mixer_fault_test#2141

Fix logging in mixer_fault_test#2141
dmitri-d wants to merge 51 commits intoistio:release-1.1from
dmitri-d:fix-logging

dmitri-d commented Mar 6, 2019

Uh oh!

kyessenov commented Mar 6, 2019

Uh oh!

istio-testing commented Mar 6, 2019

Uh oh!

dmitri-d commented Mar 6, 2019

Uh oh!

duderino commented Mar 12, 2019

Uh oh!

istio-testing commented Mar 12, 2019

Uh oh!

venilnoronha left a comment

Uh oh!

istio-testing commented Mar 20, 2019

Uh oh!

googlebot commented Mar 20, 2019

Uh oh!

istio-testing commented Mar 20, 2019

Uh oh!

dmitri-d commented Mar 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

dmitri-d commented Mar 6, 2019

Uh oh!

kyessenov commented Mar 6, 2019

Uh oh!

istio-testing commented Mar 6, 2019

Uh oh!

dmitri-d commented Mar 6, 2019

Uh oh!

duderino commented Mar 12, 2019

Uh oh!

istio-testing commented Mar 12, 2019

Uh oh!

venilnoronha left a comment

Choose a reason for hiding this comment

Uh oh!

istio-testing commented Mar 20, 2019

Uh oh!

googlebot commented Mar 20, 2019

Uh oh!

istio-testing commented Mar 20, 2019

Uh oh!

dmitri-d commented Mar 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants