test: Wrap proto string in std::string before comparison (#4238)

jamessynge · htuch · commit 52beb067df4d · 2018-08-27T12:56:23.000-04:00
Risk Level: Low
Testing: Unit
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: James Synge &lt;jamessynge@google.com&gt;
diff --git a/test/integration/hds_integration_test.cc b/test/integration/hds_integration_test.cc
@@ -179,8 +179,9 @@ class HdsIntegrationTest : public HttpIntegrationTest,
     if (address->ip()->port() != endpoint.endpoint().address().socket_address().port_value()) {
       return false;
     }
+    // SocketAddress.address is a proto string, not std::string, so convert it before comparing.
     if (address->ip()->addressAsString() !=
-        endpoint.endpoint().address().socket_address().address()) {
+        absl::string_view(endpoint.endpoint().address().socket_address().address())) {
       return false;
     }
     return true;

Original file line number	Diff line number	Diff line change
`@@ -179,8 +179,9 @@ class HdsIntegrationTest : public HttpIntegrationTest,`
`179`	`179`	`if (address->ip()->port() != endpoint.endpoint().address().socket_address().port_value()) {`
`180`	`180`	`return false;`
`181`	`181`	`}`
	`182`	`+ // SocketAddress.address is a proto string, not std::string, so convert it before comparing.`
`182`	`183`	`if (address->ip()->addressAsString() !=`
`183`		`- endpoint.endpoint().address().socket_address().address()) {`
	`184`	`+ absl::string_view(endpoint.endpoint().address().socket_address().address())) {`
`184`	`185`	`return false;`
`185`	`186`	`}`
`186`	`187`	`return true;`