Skip to content

Update the doc about how to setup on Alibaba Cloud#9263

Merged
istio-testing merged 3 commits intoistio:masterfrom
osswangxining:master
Mar 22, 2021
Merged

Update the doc about how to setup on Alibaba Cloud#9263
istio-testing merged 3 commits intoistio:masterfrom
osswangxining:master

Conversation

@osswangxining
Copy link
Copy Markdown
Contributor

@osswangxining osswangxining commented Mar 16, 2021 •
edited by istio-policy-bot
Loading

[ ] Configuration Infrastructure
[X] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@osswangxining osswangxining requested a review from a team as a code owner March 16, 2021 09:31
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 16, 2021
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Mar 16, 2021
@istio-testing
Copy link
Copy Markdown
Contributor

istio-testing commented Mar 16, 2021

Hi @osswangxining. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kebe7jun kebe7jun added the translation/chinese Translation item label Mar 16, 2021
@kebe7jun
Copy link
Copy Markdown
Member

kebe7jun commented Mar 16, 2021

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Mar 16, 2021
@kebe7jun kebe7jun removed the translation/chinese Translation item label Mar 16, 2021
@brian-avery
Copy link
Copy Markdown
Member

brian-avery commented Mar 16, 2021

/retest

1 similar comment
@brian-avery
Copy link
Copy Markdown
Member

brian-avery commented Mar 16, 2021

/retest

@istio-testing
Copy link
Copy Markdown
Contributor

istio-testing commented Mar 16, 2021

@osswangxining: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
doc.test.profile_none_istio.io 88894f4 link /test doc.test.profile_none_istio.io
doc.test.profile_default_istio.io 88894f4 link /test doc.test.profile_default_istio.io
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn
Copy link
Copy Markdown
Contributor

ericvn commented Mar 16, 2021

@brian-avery The two failing tests are known issues for which we have a release blocking issue open.

@osswangxining
Copy link
Copy Markdown
Contributor Author

osswangxining commented Mar 17, 2021

@brian-avery The two failing tests are known issues for which we have a release blocking issue open.

so can we skip this known issues for this PR or any other suggestions? @brian-avery

@osswangxining
Copy link
Copy Markdown
Contributor Author

osswangxining commented Mar 18, 2021

@brian-avery The two failing tests are known issues for which we have a release blocking issue open.

@ericvn @brian-avery any suggestions to follow up this PR? Thanks.

ericvn
ericvn reviewed Mar 18, 2021
View reviewed changes
Comment thread content/en/docs/setup/platform-setup/alicloud/index.md

This page was last updated August 8, 2018.

{{< boilerplate untested-document >}}
Copy link
Copy Markdown
Contributor

@ericvn ericvn Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The boilerplate has this text: This vendor-provided document has not been tested on the Istio 1.9 release and may contain bugs. If you feel that is accurate, you can leave it in, else you could remove it.

Copy link
Copy Markdown
Contributor Author

@osswangxining osswangxining Mar 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can leave it in and go ahead. Thanks for your reply.

@osswangxining
Copy link
Copy Markdown
Contributor Author

osswangxining commented Mar 22, 2021

@ericvn what I need to add for this PR to be merged? thanks for your guide!

@istio-testing istio-testing merged commit f7a11de into istio:master Mar 22, 2021
istio-testing added a commit that referenced this pull request Mar 24, 2021
@wbartosz @howardjohn
@istio-testing @linsun @jacob-delgado @bianpengyuan @hzxuzhonghu @yangminzhu @dsm-dc @kebe7jun @lxd5866 @wzshiming @Ruil1n @MXuDong @smawson @efabens @zackzhangkai @GregHanson @scwang18 @gabriel9895 @orangegzx @Alan-Cha @elkan1788 @mhindery @frankbu @zc2638 @mageluoen @zhaosimon @k-9527 @davidhauck @johnzheng1975 @dapengJacky @TianTianBigWang @bvandewalle @osswangxining @wangmeng @ceastman-ibm @imgbot @ImgBotApp
Polidea update (#9383