Skip to content

zh-translation: blog series#5969

Merged
istio-testing merged 9 commits intoistio:masterfrom
3ks:zh-trans-blog-series
Dec 4, 2019
Merged

zh-translation: blog series#5969
istio-testing merged 9 commits intoistio:masterfrom
3ks:zh-trans-blog-series

Conversation

@3ks
Copy link
Copy Markdown
Member

@3ks 3ks commented Dec 4, 2019

@3ks 3ks requested a review from a team as a code owner December 4, 2019 11:37
@istio-policy-bot istio-policy-bot added the translation/chinese Translation item label Dec 4, 2019
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 4, 2019
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 4, 2019
@istio-testing
Copy link
Copy Markdown
Contributor

istio-testing commented Dec 4, 2019

Hi @gorda. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3ks
Copy link
Copy Markdown
Member Author

3ks commented Dec 4, 2019

/need-ok-to-test @rootsongjc

@rootsongjc
Copy link
Copy Markdown
Member

rootsongjc commented Dec 4, 2019

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Dec 4, 2019
@rootsongjc rootsongjc self-assigned this Dec 4, 2019
rootsongjc
rootsongjc approved these changes Dec 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@istio-testing istio-testing merged commit f207adb into istio:master Dec 4, 2019
@3ks 3ks deleted the zh-trans-blog-series branch December 8, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rootsongjc rootsongjc rootsongjc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rootsongjc rootsongjc

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/chinese Translation item

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@3ks @istio-testing @rootsongjc @googlebot @istio-policy-bot