[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: objectiser
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ostromart

Assign the PR to them by writing /assign @ostromart in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

cc @rshriram

/assign @gyliu513

Codecov Report

Merging #6983 into release-1.0 will increase coverage by 1%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-1.0   #6983    +/-   ##
============================================
+ Coverage           71%     71%    +1%     
============================================
  Files              360     360            
  Lines            31197   31257    +60     
============================================
+ Hits             22043   22155   +112     
+ Misses            8285    8234    -51     
+ Partials           869     868     -1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a37e4b...5bdc6a9. Read the comment docs.

Jaeger and tracing(zipkin api) ingress conflicts as there're using the same hosts, same annotations, etc.

I suggest this:

tracing:
  enabled: true
  jaeger:
    enabled: false
    memory:
      max_traces: 50000
    ingress:
      enabled: false
      # Used to create an Ingress record.
      hosts:
        - jaeger.local
      annotations:
        # kubernetes.io/ingress.class: nginx
        # kubernetes.io/tls-acme: "true"
      tls:
        # Secrets must be manually created in the namespace.
        # - secretName: jaeger-tls
        #   hosts:
        #     - jaeger.local

or use different ingress paths

@sebastien-prudhomme I'll create a PR with your suggested solution - although just wondering if rather than having jaeger.ingress.enabled, whether the ingress.enabled could still be used - but the jaeger-query ingress is only created if jaeger.enabled is also true.