…siness. (istio#639)

* Update the symbol names for all ConfigErrors to adopt camelCase consistently.

* Only log from the dedup repear at a higher logging level to avoid noisiness.


Former-commit-id: eb66b0c3d8826cec935ce5a6eec709abdbcdd7c5

…siness. (#639)

* Update the symbol names for all ConfigErrors to adopt camelCase consistently.

* Only log from the dedup repear at a higher logging level to avoid noisiness.


Former-commit-id: 8f5bdba213890dc650b62494c08cbc089f5a317e

* Fixes for istiod injection

Right now there is no way to remove the sidecar injector deployment when
using istiod. This means you will always have a bunch of config that is
unused. Instead, when istiod is enabled, remove the injector stuff.

Alternative approach would be to add an explicit flag for this, like
istiod.disableinjector or something, but I am not sure that is needed at
this time.

Additionally, add back features from the old injection to avoid
regressions. These are critical features, not just legacy junk.

Finally, reuse the old name for the configmap so existing tooling like
istioctl can continue to function correctly.

* Fix tests

* Add unit test and fix for ICP.DeepCopy()

DeepCopy() always failed with an error, which was only logged and wasn't
handled properly. The error occured when unmarshalling CreatedTimestamp,
which meant that all remaining fields were never unmarshalled.

* Add copyright header

* Update go.mod

* Add additional test and fix import formatting