Skip to content

use client-go's default client config loading rules#5300

Merged
linsun merged 1 commit intoistio:masterfrom
ayj:use-default-client-config-loading-rules
Apr 30, 2018
Merged

use client-go's default client config loading rules#5300
linsun merged 1 commit intoistio:masterfrom
ayj:use-default-client-config-loading-rules

Conversation

@ayj
Copy link
Copy Markdown
Contributor

@ayj ayj commented Apr 30, 2018

Potentially fixes #5255

@ayj ayj requested review from esnible and linsun April 30, 2018 18:59
@ayj
Copy link
Copy Markdown
Contributor Author

ayj commented Apr 30, 2018

This might also address #4938, though I haven't tested that yet. cc @Rigdon

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 30, 2018

@ayj: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-bookInfoTests-v1alpha3.sh 07fe75a link /test e2e-bookInfo-envoyv2-v1alpha3
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linsun
Copy link
Copy Markdown
Member

linsun commented Apr 30, 2018

Thank you @ayj I will pull the change locally to test it.

@linsun
Copy link
Copy Markdown
Member

linsun commented Apr 30, 2018

it works quite nicely, thanks much @ayj!

~/go/src/github.com/linsun/examples/guestbook-go on  master! ⌚ 16:19:03
$ istioctl kube-inject -f guestbook-deployment.yaml --debug
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  creationTimestamp: null
  labels:
    app: guestbook-v1
    version: "1.0"

@linsun
Copy link
Copy Markdown
Member

linsun commented Apr 30, 2018

is this something worthy adding a test case @ayj ? it can be a follow up PR.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 30, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: linsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linsun linsun mentioned this pull request Apr 30, 2018
Closed
@linsun linsun merged commit b109752 into istio:master Apr 30, 2018
bianpengyuan pushed a commit to bianpengyuan/istio that referenced this pull request Apr 30, 2018
@ayj @bianpengyuan
use client-go's default client config loading rules (istio#5300)
c70a275
@esnible esnible mentioned this pull request May 1, 2018
Closed
@linsun
Copy link
Copy Markdown
Member

linsun commented May 1, 2018 •
edited
Loading

Note: this one should be in 0.8 too and i merged to master accidentally (should be in 0.8 in first place).

@linsun linsun mentioned this pull request May 9, 2018
Closed
@esnible esnible mentioned this pull request May 11, 2018
Merged
@ayj ayj deleted the use-default-client-config-loading-rules branch October 17, 2018 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linsun linsun linsun approved these changes

@esnible esnible Awaiting requested review from esnible

Assignees

@linsun linsun

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

istioctl register/unregister cmd failed

4 participants

@ayj @istio-testing @linsun @googlebot