Upgrade rules_go to 0.5.2 by lizan · Pull Request #508 · istio/istio

lizan · 2017-07-28T22:08:22Z

Fixes #429

lizan · 2017-07-28T22:24:13Z

Note this will require Bazel 0.5.2 or newer for building. DO NOT MERGE until test infra gets update.

istio-testing · 2017-07-28T22:30:04Z

Jenkins job istio/presubmit passed

ldemailly

thx, what's the PR for updating bazel in test infra?

ldemailly · 2017-07-28T22:46:56Z

I wonder why jenkins is happy and prow isn't

istio-testing · 2017-07-31T18:31:14Z

Jenkins job istio/presubmit passed

istio-testing · 2017-07-31T18:33:19Z

Jenkins job istio/presubmit passed

lizan · 2017-07-31T19:49:10Z

/retest

lizan · 2017-07-31T22:30:07Z

@sebastienvas @yutongz When can this be merged? Prow seems failing every PR at the moment.

yutongz · 2017-07-31T22:55:22Z

/test all

ldemailly · 2017-07-31T23:49:29Z

/approve

istio-merge-robot · 2017-07-31T23:50:02Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ldemailly, lizan
We suggest the following additional approvers:

Assign the PR to them by writing /assign in a comment when ready.

Associated issue: 429

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

yutongz · 2017-07-31T23:54:29Z

@ldemailly The OWNERS file just got merged in. So now, if you would like to try "/approve" again, it should work :)

sebastienvas · 2017-07-31T23:55:43Z

We already using bazel 0.5.2.

istio-testing · 2017-07-31T23:57:07Z

Jenkins job istio/presubmit passed

istio-testing · 2017-08-01T00:22:34Z

Jenkins job istio/presubmit passed

sebastienvas · 2017-08-01T01:42:18Z

This is also fails for me. The linter is broken. Jenkins does run the linters as no go files has been updated but prow does not have this optimization.

sebastienvas

Please check linters on your marchine as well

lizan · 2017-08-01T17:59:07Z

@sebastienvas linters even fails on master, with same messages.

sebastienvas · 2017-08-02T02:40:10Z

I am not convinced. We submitted multiple PRs today without failures.

…

On Aug 1, 2017 11:00 AM, "istio-bot" ***@***.***> wrote: @lizan <https://github.com/lizan>: The following test *failed*, say /retest to rerun them all: Test name Commit Details Rerun command prow/istio-presubmit.sh d93f0ad <d93f0ad> link <https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/508/istio-presubmit/158/> @istio-testing bazel test this Instructions for interacting with me using PR comments are available here <https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://github.com/kubernetes/test-infra/blob/master/commands.md>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#508 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQ80Z4EtDJONId_pWYlthun6kl8-wmkOks5sT2fYgaJpZM4OnIT9> .

ldemailly · 2017-08-02T04:49:28Z

merged as it passed linters on prow/istio-presubmit.sh (not sure where Jenkins presubmit went)

sebastienvas · 2017-08-02T18:16:18Z

Jenkins presubmit is disabled because there are too many tests running on the e2e cluster.

* Upgrade rules_go to 0.5.2 * Fix bazel_to_go.py to vendor go_repository Former-commit-id: 57d806c

* add missing istio-reader service account and binding * make gen

Co-authored-by: maistra-bot <null>

…tio#508)

Update the path for Envoy proxy SHA

Added a function to check the stability of OpenShift cluster operators before running tests. Co-authored-by: Francisco Herrera <[email protected]>

googlebot added the cla: yes label Jul 28, 2017

ldemailly approved these changes Jul 28, 2017

View reviewed changes

sebastienvas suggested changes Aug 1, 2017

View reviewed changes

istio-merge-robot added the approved label Aug 1, 2017

ldemailly mentioned this pull request Aug 2, 2017

bazel 0.5.x build error on macos #429

Closed

Upgrade rules_go to 0.5.2

a62aa9b

lizan force-pushed the bazel_053_fix branch from e07d280 to a62aa9b Compare August 2, 2017 03:28

Fix bazel_to_go.py to vendor go_repository

755cc6e

ldemailly merged commit 57d806c into istio:master Aug 2, 2017

rshriram pushed a commit that referenced this pull request Oct 30, 2017

Upgrade rules_go to 0.5.2 (#508)

2e8406a

* Upgrade rules_go to 0.5.2 * Fix bazel_to_go.py to vendor go_repository Former-commit-id: 57d806c

vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017

Upgrade rules_go to 0.5.2 (istio#508)

b91e2bb

* Upgrade rules_go to 0.5.2 * Fix bazel_to_go.py to vendor go_repository Former-commit-id: 57d806c

mandarjog pushed a commit that referenced this pull request Nov 2, 2017

Upgrade rules_go to 0.5.2 (#508)

dab13f5

* Upgrade rules_go to 0.5.2 * Fix bazel_to_go.py to vendor go_repository Former-commit-id: 57d806c

howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020

add missing istio-reader service account and binding (istio#508)

7e8492c

* add missing istio-reader service account and binding * make gen

luksa pushed a commit to luksa/istio that referenced this pull request Sep 20, 2022

Automator: Update proxy (istio#508)

e8478c0

Co-authored-by: maistra-bot <null>

antonioberben pushed a commit to antonioberben/istio that referenced this pull request Jan 29, 2024

[jaeger] Added imagePullSecrets option for all-in-one deployment. (is…

ca66cf1

…tio#508)

vikaschoudhary16 pushed a commit to vikaschoudhary16/istio that referenced this pull request Aug 12, 2024

Merge pull request istio#508 from tetrateio/port/1.21/envoy-proxy-sha

e742630

Update the path for Envoy proxy SHA

dgn pushed a commit to dgn/istio that referenced this pull request Feb 17, 2026

Implement cluster operator stability check (istio#508)

d6c1fa4

Added a function to check the stability of OpenShift cluster operators before running tests. Co-authored-by: Francisco Herrera <[email protected]>

Conversation

lizan commented Jul 28, 2017

Uh oh!

lizan commented Jul 28, 2017

Uh oh!

istio-testing commented Jul 28, 2017

Uh oh!

ldemailly left a comment

Choose a reason for hiding this comment

Uh oh!

ldemailly commented Jul 28, 2017

Uh oh!

istio-testing commented Jul 31, 2017

Uh oh!

istio-testing commented Jul 31, 2017

Uh oh!

lizan commented Jul 31, 2017

Uh oh!

lizan commented Jul 31, 2017

Uh oh!

yutongz commented Jul 31, 2017

Uh oh!

ldemailly commented Jul 31, 2017

Uh oh!

istio-merge-robot commented Jul 31, 2017

Uh oh!

yutongz commented Jul 31, 2017

Uh oh!

sebastienvas commented Jul 31, 2017

Uh oh!

istio-testing commented Jul 31, 2017

Uh oh!

istio-testing commented Aug 1, 2017

Uh oh!

sebastienvas commented Aug 1, 2017

Uh oh!

sebastienvas left a comment

Choose a reason for hiding this comment

Uh oh!

lizan commented Aug 1, 2017

Uh oh!

sebastienvas commented Aug 2, 2017 via email

Uh oh!

ldemailly commented Aug 2, 2017

Uh oh!

sebastienvas commented Aug 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants