Skip to content

unify cobra args validation. #42622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yanggangtony wants to merge 1 commit into from
Closed

unify cobra args validation. #42622

yanggangtony wants to merge 1 commit into from

Conversation

@yanggangtony
Copy link
Member

@yanggangtony yanggangtony commented Dec 31, 2022

Signed-off-by: yanggang [email protected]

/kind cleanup

Let cobra args unify, for the validation logic.

@yanggangtony yanggangtony requested a review from a team as a code owner December 31, 2022 08:55
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 31, 2022
@istio-testing
Copy link
Collaborator

istio-testing commented Dec 31, 2022

Hi @yanggangtony. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

howardjohn
howardjohn reviewed Jan 2, 2023
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a regression as we loose helpful error messages

@yanggangtony
Copy link
Member Author

yanggangtony commented Jan 5, 2023

this seems like a regression as we loose helpful error messages

Hi, just close the pr , is that ok?

@zhlsunshine
Copy link
Contributor

zhlsunshine commented Jan 9, 2023

Hi @yanggangtony, why this unify args validation?

@yanggangtony
Copy link
Member Author

yanggangtony commented Jan 9, 2023

Hi @yanggangtony, why this unify args validation?

@zhlsunshine
because i think it is can be done well by cobra .
And there are some place use cobra args validation , and some places not..
What's your point about these and do you think it is necesary?

@zhlsunshine
Copy link
Contributor

zhlsunshine commented Jan 9, 2023

Hi @yanggangtony, why this unify args validation?

@zhlsunshine because i think it is can be done well by cobra . And there are some place use cobra args validation , and some places not.. What's your point about these and do you think it is necesary?

Hi @yanggangtony, IMO, it's unnecessary to do this kind of verification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn left review comments

Assignees

No one assigned

Labels

needs-ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yanggangtony @istio-testing @zhlsunshine @howardjohn