istioctl x proxy-status via istio agents.#40623
Merged
istio-testing merged 9 commits intoistio:masterfrom Sep 17, 2022
Merged
Conversation
istio-testing
added
the
size/L
ingwonsong
added
the
release-notes-none
zirain
reviewed
Aug 24, 2022
zirain
reviewed
Aug 24, 2022
ingwonsong
force-pushed
the
istio-ps-via-agent
branch
from
2c7af56 to
3e1aa6f
Compare
ingwonsong
force-pushed
the
istio-ps-via-agent
branch
from
3e1aa6f to
c36f181
Compare
hzxuzhonghu
reviewed
Aug 24, 2022
howardjohn
reviewed
Aug 24, 2022
ingwonsong
force-pushed
the
istio-ps-via-agent
branch
from
0290557 to
751224d
Compare
hzxuzhonghu
reviewed
Aug 26, 2022
ingwonsong
force-pushed
the
istio-ps-via-agent
branch
from
eecfec6 to
7d21e6f
Compare
hzxuzhonghu
approved these changes
Aug 27, 2022
Contributor
Author
|
@therealmitchconnors Wam reminder |
ingwonsong
force-pushed
the
istio-ps-via-agent
branch
from
7d21e6f to
e2a7cad
Compare
Contributor
Author
|
To wait for #40721, I set this to |
Contributor
Author
|
As #40721 supports the 15004 port as well, don't need to wait for the PR. |
ingwonsong
added
area/user experience
and removed
do-not-merge
ingwonsong
force-pushed
the
istio-ps-via-agent
branch
from
e2a7cad to
0fa5de9
Compare
Co-authored-by: John Howard <[email protected]>
ingwonsong
force-pushed
the
istio-ps-via-agent
branch
from
6901a76 to
ff19141
Compare
therealmitchconnors
approved these changes
Sep 17, 2022
Contributor
Author
|
/retest |
ingwonsong
added a commit
to ingwonsong/istio
that referenced
this pull request
Sep 17, 2022
* `istioctl ps` via istio agents. * Fix lint errors * Fix lint errors * Use k8s client_go instead of RESTClient * Update pkg/kube/client.go Co-authored-by: John Howard <[email protected]> * Use constant for "status.phase=Running" * Use the revision in the annotation instead of labels for the injected pods * Add xds-via-agents-limit flag * Reflect the comments and refactoring Co-authored-by: John Howard <[email protected]>
This was referenced Sep 17, 2022
ingwonsong
added a commit
to ingwonsong/istio
that referenced
this pull request
Sep 18, 2022
* `istioctl ps` via istio agents. * Fix lint errors * Fix lint errors * Use k8s client_go instead of RESTClient * Update pkg/kube/client.go Co-authored-by: John Howard <[email protected]> * Use constant for "status.phase=Running" * Use the revision in the annotation instead of labels for the injected pods * Add xds-via-agents-limit flag * Reflect the comments and refactoring Co-authored-by: John Howard <[email protected]>
Contributor
Author
|
/cherrypick release-1.15 |
Collaborator
|
@ingwonsong: #40623 failed to apply on top of branch "release-1.15": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Collaborator
|
@ingwonsong: new issue created for failed cherrypick: #41040 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
istio-testing
pushed a commit
that referenced
this pull request
Sep 19, 2022
* `istioctl ps` via istio agents. * Fix lint errors * Fix lint errors * Use k8s client_go instead of RESTClient * Update pkg/kube/client.go Co-authored-by: John Howard <[email protected]> * Use constant for "status.phase=Running" * Use the revision in the annotation instead of labels for the injected pods * Add xds-via-agents-limit flag * Reflect the comments and refactoring Co-authored-by: John Howard <[email protected]> Co-authored-by: John Howard <[email protected]>
ingwonsong
added a commit
to ingwonsong/istio
that referenced
this pull request
Sep 19, 2022
* `istioctl ps` via istio agents. * Fix lint errors * Fix lint errors * Use k8s client_go instead of RESTClient * Update pkg/kube/client.go Co-authored-by: John Howard <[email protected]> * Use constant for "status.phase=Running" * Use the revision in the annotation instead of labels for the injected pods * Add xds-via-agents-limit flag * Reflect the comments and refactoring Co-authored-by: John Howard <[email protected]>
istio-testing
pushed a commit
that referenced
this pull request
Sep 19, 2022
* Send only the Cluster ID (#40477) * Add Tap gRPC handler to Istio Agent. (#40566) * Add Tap GRPC handler to Istio Agent. * Fix lint errors * Add the integration test * `istioctl x proxy-status` via istio agents. (#40623) * `istioctl ps` via istio agents. * Fix lint errors * Fix lint errors * Use k8s client_go instead of RESTClient * Update pkg/kube/client.go Co-authored-by: John Howard <[email protected]> * Use constant for "status.phase=Running" * Use the revision in the annotation instead of labels for the injected pods * Add xds-via-agents-limit flag * Reflect the comments and refactoring Co-authored-by: John Howard <[email protected]> Co-authored-by: John Howard <[email protected]>
ingwonsong
added a commit
to ingwonsong/istio
that referenced
this pull request
Oct 25, 2022
* `istioctl ps` via istio agents. * Fix lint errors * Fix lint errors * Use k8s client_go instead of RESTClient * Update pkg/kube/client.go Co-authored-by: John Howard <[email protected]> * Use constant for "status.phase=Running" * Use the revision in the annotation instead of labels for the injected pods * Add xds-via-agents-limit flag * Reflect the comments and refactoring Co-authored-by: John Howard <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes an experimental option
--xds-via-agentsonly foristioctl x proxy-statuscommand, which sends a query foristioctl x proxy-statusvia istio agents, instead of direct query toistiod.istioctl x proxy-statustry to find all the istiod instances by searching pods inistio-systemnamespace.But, if we use the external istiods, this way may not work.
For example,
istiodcan be deployed in the other cluster or out of K8S. Moreover, in front of the istiod instances, some sort of load balancer can be set to distribute the connections to multiple istiods. This kind of configuration may happen when the customer want to isolate their control plane from the workloads, or when they are using some managed control plane.In such case,
istioctl x proxy-statuscannot enumerate and access to each istiod instance directly. So, this PR proposes to accessistiodvia "istio agent".Please note that, by #40566, we can make a query to istiod via istio agents efficiently.