Skip to content

Update proxy sha#28500

Merged
istio-testing merged 3 commits intoistio:masterfrom
bianpengyuan:update-proxy
Nov 9, 2020
Merged

Update proxy sha#28500
istio-testing merged 3 commits intoistio:masterfrom
bianpengyuan:update-proxy

Conversation

@bianpengyuan
Copy link
Copy Markdown
Contributor

@bianpengyuan bianpengyuan commented Nov 2, 2020 •
edited by istio-policy-bot
Loading

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Pull Request Attributes

Please check any characteristics that apply to this pull request.

[ ] Does not have any changes that may affect Istio users.

@bianpengyuan bianpengyuan requested a review from a team November 2, 2020 21:44
@bianpengyuan bianpengyuan requested a review from a team as a code owner November 2, 2020 21:44
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 2, 2020
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 2, 2020
@bianpengyuan bianpengyuan added the release-notes-none Indicates a PR that does not require release notes. label Nov 2, 2020
@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented Nov 2, 2020

/retest

@bianpengyuan bianpengyuan mentioned this pull request Nov 2, 2020
Closed
@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented Nov 2, 2020

/retest

Known flake: #28315

@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented Nov 2, 2020

Looks like proxy somehow never becomes ready: https://storage.googleapis.com/istio-prow/pr-logs/pull/istio_istio/28500/integ-security-k8s-tests_istio/1323388107118088192/artifacts/security-3f86303d15a44484b894a6/TestMtlsHealthCheck/_test_context/healthcheck-20-79114-state326770396/cluster-0/rewrite-success-v1-948484486-w7g6r_istio-proxy.log

@howardjohn
Copy link
Copy Markdown
Member

howardjohn commented Nov 3, 2020

Deployed locally

netstat -nl shows no envoy listeners. /listeners shows them

logs.txt

Relevant parts:

2020-11-03T01:05:59.057019Z     debug   envoy init      added target Listener-init-target 3cd758c7-edf2-4af3-8d4a-6227cd92e5ac to init manager Server
2020-11-03T01:05:59.057035Z     debug   envoy config    Create listen socket for listener 3cd758c7-edf2-4af3-8d4a-6227cd92e5ac on address 0.0.0.0:15021
2020-11-03T01:05:59.057039Z     debug   envoy config    Set listener 3cd758c7-edf2-4af3-8d4a-6227cd92e5ac socket factory local address to 0.0.0.0:15021
2020-11-03T01:05:59.057041Z     debug   envoy config    add active listener: name=3cd758c7-edf2-4af3-8d4a-6227cd92e5ac, hash=9872086206848846795, address=0.0.0.0:15021

@howardjohn
Copy link
Copy Markdown
Member

howardjohn commented Nov 3, 2020

Hm, I notice it also has no dynamic listeners. I think it requests CDS from istiod but never lds:

2020-11-03T01:08:54.214761Z     info    ads     ADS: new connection for node:sidecar~10.88.2.147~svc00-0-7-0-7b7c4664b-lwfqt.service-graph00~service-graph00.svc.cluster.local-3499
2020-11-03T01:08:54.216627Z     info    ads     CDS: PUSH for node:svc00-0-7-0-7b7c4664b-lwfqt.service-graph00 resources:38 size:34.6kB
2020-11-03T01:08:54.216802Z     info    ads     EDS: PUSH for node:svc00-0-7-0-7b7c4664b-lwfqt.service-graph00 resources:34 empty:0 cached:34/34

@lambdai lambdai mentioned this pull request Nov 3, 2020
Closed
@howardjohn
Copy link
Copy Markdown
Member

howardjohn commented Nov 4, 2020

/retest

@ericvn
Copy link
Copy Markdown
Contributor

ericvn commented Nov 4, 2020

/retest

@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented Nov 4, 2020

So.. looks like SDS change is not the root cause? We are still seeing blocked start up here.. cc @lambdai

@howardjohn
Copy link
Copy Markdown
Member

howardjohn commented Nov 4, 2020

the revert was only for 1 of the 2 envoy PRs. maybe the other one broke the warming

@lambdai
Copy link
Copy Markdown
Contributor

lambdai commented Nov 4, 2020

envoyproxy/envoy#13875 may fix the envoy cluster never ready which we are seeing in this thread.

And the reverted PR is to address cluster early ready. Lizan has some long term and short term plan.

@ericvn ericvn mentioned this pull request Nov 4, 2020
Merged
@jacob-delgado jacob-delgado mentioned this pull request Nov 5, 2020
Merged
@lambdai lambdai mentioned this pull request Nov 6, 2020
Closed
@istio-testing istio-testing merged commit e35871e into istio:master Nov 9, 2020
@incfly incfly mentioned this pull request Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn approved these changes

@ericvn ericvn ericvn approved these changes

@costinm costinm Awaiting requested review from costinm costinm is a code owner

@linsun linsun Awaiting requested review from linsun linsun is a code owner

+1 more reviewer

@gargnupur gargnupur gargnupur approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bianpengyuan @howardjohn @ericvn @lambdai @gargnupur @istio-testing