Conversation
| ) | ||
|
|
||
| func ConstructCustomDNSNames(serviceAccounts []string, serviceNames []string, | ||
| namespace string, customDNSNames string) map[string]*DNSNameEntry { |
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
| }, | ||
| ns: "istio-system", | ||
| dnsNames: "istio-galley-service-account.istio-system:istio-galley-ilb.istio-system.svc.us1," + | ||
| "istio-galley-service-account.istio-system:istio-galley-ilb.istio-system.svc.us2", |
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: myidpt, wattli The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@duderino , can you help to merge? Somehow the CLA does not work. Thanks |
|
@wattli: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
No description provided.