Merge branch 'release-1.1' into authz-v2#11930
Merged
istio-testing merged 78 commits intoistio:authz-v2from Feb 21, 2019
Merged
Merge branch 'release-1.1' into authz-v2#11930istio-testing merged 78 commits intoistio:authz-v2from
istio-testing merged 78 commits intoistio:authz-v2from
Conversation
The DNSDomain variable needs to be enhanced to include more then one DNS entry. Change DNSDomain to DNSDomains as a meta and add the dnsConfig in the meta. As now DNSDomain is a slice of strings instead of a string, the variable needs consolidation.
…le (istio#11586) (istio#11631) (cherry picked from commit f9b6866)
* Update fluentd adapter to be more robust * Minor touchup of bad merge * Lint fixes
Signed-off-by: Kuat Yessenov <[email protected]>
The Cloud Foundry open source licensing scanner has a plugin that identifies dependencies from gradle scripts, but it requires the buildscript and plugins block be before anything else in the file. This change does not affect the build, but makes our lives a smidge easier. Co-authored-by: Teal Stannard <[email protected]>
…grant access to mesh. (istio#11508) * Samples for accessing apt-get repo, Github, and pip repo * A Readme explaining the samples * Link to future doc on default external comm capability * Incorporate documentation feedback from venilnoronha
* Add support for metadata constraints in RBAC This adds support for mapping RBAC constraints with keys in the a[b] format to Envoy's filter metadata matcher. Signed-off-by: Venil Noronha <[email protected]> * Use SplitN instead of Split for completeness This updates the metadata matcher definition to use strings.SplitN instead of strings.Split in order to capture the whole binary key in two parts. Signed-off-by: Venil Noronha <[email protected]> * Accomodate [list] and plain value type constraints This adds logic to accomodate filter metadata matching over both [list] and value type constraints. Signed-off-by: Venil Noronha <[email protected]> * Add extra experimental. prefix test for matching This adds an extra experimental. prefix test while creating metadata matchers based on Envoy filters. Signed-off-by: Venil Noronha <[email protected]> * Update comments This updates code comments. Signed-off-by: Venil Noronha <[email protected]>
…Methods (istio#10778) * add POST to ratings service * put a space between if and opening parenthesis * add comments * remove extra line-break
…s synonym for toJSON (istio#11570)
* Fix ingress in pilot, writeback and multiple namespaces * Fix tests, format * Fix test - the generated service should be left in the namespace of ingress * Additional test fixes, match the new 1.1 semantics * Again make fmt and lint not matching
* Break up the helloworld sample into versions * Moved to default namespace * Seperated gateway file and added labels * Update the doc * Cleanup section updated too
…io#11640) * Add handling for independent encoding in Report batches to Mixer * fix lll * Address review * protect protobag done
* wip: exit circleci test early if setup fails Many of the circleci tests will attempt to run the e2e/integration tests even after the test setup fails. This leads to misleading test failures that suggest the problem is with the feature test and not the test setup itself. Example test runs where the setup failed and the test was run but immediately errored out because a dependency was missing: https://circleci.com/gh/istio/istio/316588 https://circleci.com/gh/istio/istio/317262 https://circleci.com/gh/istio/istio/318281 https://circleci.com/gh/istio/istio/316031 https://circleci.com/gh/istio/istio/315952 https://circleci.com/gh/istio/istio/315871 https://circleci.com/gh/istio/istio/315813 ref: https://circleci.com/docs/2.0/configuration-reference/#the-when-attribute ``` By default, CircleCI will execute job steps one at a time, in the order that they are defined in config.yml, until a step fails (returns a non-zero exit code). After a command fails, no further job steps will be executed. Adding the when attribute to a job step allows you to override this default behaviour, and selectively run or skip steps depending on the status of the job. The default value of on_success means that the step will run only if all of the previous steps have been successful (returned exit code 0). A value of always means that the step will run regardless of the exit status of previous steps. This is useful if you have a task that you want to run regardless of whether the previous steps are successful or not. For example, you might have a job step that needs to upload logs or code-coverage data somewhere. ``` * re-add `when: always` to codecov job
* Implementation of isolation for EDS * Provide nil proxy for older calls * Always call loadAssignmentsForClusterIsolated * Revert "Always call loadAssignmentsForClusterIsolated" This reverts commit db2c997. * Env variable to disable * Lint
…s. (istio#11630) * Feature flag graceful shutdown Turn graceful shutdown off by default for 1.1 with a feature flag that allows users to opt-in. Signed-off-by: Liam White <[email protected]> * Address pr comments Signed-off-by: Liam White <[email protected]> * Clean up missed feature flag var Signed-off-by: Liam White <[email protected]> * Add turn off test case, todo comments and fix agent tests Signed-off-by: Liam White <[email protected]> * fix lint Signed-off-by: Liam White <[email protected]> * PR review comments Signed-off-by: Liam White <[email protected]> * Move TerminationDuration function and tests to Pilot features Signed-off-by: Liam White <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Make sure empty proxy locality will fall back to using proxy service's instance locality.
* cache ServiceAccounts and remove it drom Environment * use allServices var * fix ut
* new proxy sha for release-1.1 * Run deps ensure to api * right sha
* Added new counters from istio#8224 to Mixer client tests. * Reformat
* use CredentialName for SIMPLE * cvc * rootca * update test. * update test * fix format * update gateway config * fix test * fix lint * fix test * add comments. * add nolint * update cvc * update * update * update * update * update * update * format * dep ensure --update istio.io/api * Revise per comments * Revise * lint * Marshal SDS call credential config using deterministic order * update * update * revise * add comment * update
* move MCP settings to meshConfig Signed-off-by: Shriram Rajagopalan <[email protected]> * fix cert bug
* Fix listener parsing with ipv6 addresses Signed-off-by: Serguei Bezverkhi <[email protected]> * Fixing typo Signed-off-by: Serguei Bezverkhi <[email protected]>
…pe (istio#11858) * add sample file to expose bookinfo productpage service as nodeport type * address comment
* build network filters in inbound path Signed-off-by: Shriram Rajagopalan <[email protected]> * assorted fixes Signed-off-by: Shriram Rajagopalan <[email protected]> * fix network filter stack Signed-off-by: Shriram Rajagopalan <[email protected]>
Collaborator
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
googlebot
added
the
cla: no
yangminzhu
force-pushed
the
merge-1-1
branch
from
a77993a to
aad8829
Compare
yangminzhu
added
cla: yes
and removed
cla: no
Collaborator
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Collaborator
|
@yangminzhu: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Member
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pitlv2109, yangminzhu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged with command
git merge release-1-1and resolved conflicts manually (mainly in therbac_test.gofile)./cc @liminw