Skip to content

Remove the istio-remote chart and make it an istio chart values #11307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenchenglu merged 13 commits into from
Feb 6, 2019
Merged

Remove the istio-remote chart and make it an istio chart values #11307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
82789df
Remove the istio-remote chart and make it an istio chart values
ymesika Jan 27, 2019
ea67c2d
By default tracing should be disabled in remote as it's unsupported
ymesika Jan 28, 2019
b04010b
Fixing the path to values file in e2e MC test
ymesika Feb 2, 2019
586f4eb
Merge branch 'release-1.1' into removeIstioRemoteChart
ymesika Feb 2, 2019
751f87b
Fixing istio-pilot-multicluster-e2e.sh
ymesika Feb 2, 2019
d292b50
Correction for previous commit
ymesika Feb 2, 2019
a3ee447
Better way to remove MeshPolicy on remote yaml
ymesika Feb 2, 2019
b5e3199
Newline
ymesika Feb 2, 2019
4f4bb4b
Newline
ymesika Feb 2, 2019
1f3b1af
Merge branch 'release-1.1' into removeIstioRemoteChart
ymesika Feb 4, 2019
e77b7a2
Merge branch 'release-1.1' into removeIstioRemoteChart
ymesika Feb 5, 2019
15d9fe0
Merge branch 'release-1.1' into removeIstioRemoteChart
ymesika Feb 5, 2019
b675c70
Remove redundant and
ymesika Feb 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ install/kubernetes/istio-remote.yaml
install/kubernetes/istio-mcp.yaml
install/kubernetes/istio-auth-mcp.yaml
install/kubernetes/helm/istio/requirements.lock
install/kubernetes/helm/istio-remote/requirements.lock
samples/bookinfo/platform/consul/bookinfo.sidecars.yaml
*.orig
# Avoid accidental istio.VERSION changes
Expand Down
7 changes: 4 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,13 +635,14 @@ helm-repo-add:
istio-remote.yaml: $(HELM) $(HOME)/.helm helm-repo-add
cat install/kubernetes/namespace.yaml > install/kubernetes/$@
cat install/kubernetes/helm/istio-init/files/crd-* >> install/kubernetes/$@
$(HELM) dep update --skip-refresh install/kubernetes/helm/istio-remote
$(HELM) dep update --skip-refresh install/kubernetes/helm/istio
Copy link
Copy Markdown
Contributor

@costinm costinm Feb 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a separate PR we should move back the charts so dep update is not needed ( was added to allow sharing of charts with istio-remote)

Copy link
Copy Markdown
Member Author

@ymesika ymesika Feb 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @costinm, that's the plan

$(HELM) template --name=istio --namespace=istio-system \
--values install/kubernetes/helm/istio/values-istio-remote.yaml \
--set istio_cni.enabled=${ENABLE_ISTIO_CNI} \
${EXTRA_HELM_SETTINGS} \
install/kubernetes/helm/istio-remote >> install/kubernetes/$@
install/kubernetes/helm/istio >> install/kubernetes/$@

# create istio-remote.yaml
# create istio-init.yaml
istio-init.yaml: $(HELM) $(HOME)/.helm helm-repo-add
cat install/kubernetes/namespace.yaml > install/kubernetes/$@
cat install/kubernetes/helm/istio-init/files/crd-* >> install/kubernetes/$@
Expand Down
6 changes: 3 additions & 3 deletions bin/linters.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,9 @@ function run_golangcilint() {
}

function run_helm_lint() {
echo 'Running helm lint on istio & istio-remote ....'
helm lint ./install/kubernetes/helm/{istio,istio-remote}
echo 'helm lint on istio & istio-remote OK'
echo 'Running helm lint on istio ....'
helm lint ./install/kubernetes/helm/istio
echo 'helm lint on istio OK'
}

function check_grafana_dashboards() {
Expand Down
21 changes: 0 additions & 21 deletions install/kubernetes/helm/istio-remote/.helmignore
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions install/kubernetes/helm/istio-remote/Chart.yaml
View file
Open in desktop

This file was deleted.

202 changes: 0 additions & 202 deletions install/kubernetes/helm/istio-remote/LICENSE
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions install/kubernetes/helm/istio-remote/README.md
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions install/kubernetes/helm/istio-remote/requirements.yaml
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions install/kubernetes/helm/istio-remote/templates/NOTES.txt
View file
Open in desktop

This file was deleted.

43 changes: 0 additions & 43 deletions install/kubernetes/helm/istio-remote/templates/_affinity.tpl
View file
Open in desktop

This file was deleted.

30 changes: 0 additions & 30 deletions install/kubernetes/helm/istio-remote/templates/_helpers.tpl
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions install/kubernetes/helm/istio-remote/templates/_podDisruptionBudget.tpl
View file
Open in desktop

This file was deleted.

Loading