Merged
Conversation
Signed-off-by: Kuat Yessenov <[email protected]>
…stio#10492) See issue istio#10487 - kubernetes-pods job is now keeping all targets without sidecar or with expicit prometheus.io/scheme=http annotation - kubernetes-pods-istio-secure is now discarding targets with expicit prometheus.io/scheme=http annotation
* Relax test for kubeenv metric to only error on 'unknowns' * Add check to ensure that at least one metric is found * Address lint issues
* Fix Citadel Kube JWT authentication. * Small fix. * Fix unittest. * Add unit test for coverage.
* Sidecar config implementation Signed-off-by: Shriram Rajagopalan <[email protected]> * build fixes Signed-off-by: Shriram Rajagopalan <[email protected]> * adding CRD template Signed-off-by: Shriram Rajagopalan <[email protected]> * format Signed-off-by: Shriram Rajagopalan <[email protected]> * model.Sidecar to model.SidecarProxy Signed-off-by: Shriram Rajagopalan <[email protected]> * nits * gen files in galley Signed-off-by: Shriram Rajagopalan <[email protected]> * nit Signed-off-by: Shriram Rajagopalan <[email protected]> * test fix Signed-off-by: Shriram Rajagopalan <[email protected]> * e2e tests Signed-off-by: Shriram Rajagopalan <[email protected]> * comments Signed-off-by: Shriram Rajagopalan <[email protected]> * compile fix Signed-off-by: Shriram Rajagopalan <[email protected]> * final snafu Signed-off-by: Shriram Rajagopalan <[email protected]> * fix yaml path * typo * bad file name * future work Signed-off-by: Shriram Rajagopalan <[email protected]> * fix bad namespace * assorted fixes Signed-off-by: Shriram Rajagopalan <[email protected]> * fixing CDS Signed-off-by: Shriram Rajagopalan <[email protected]> * formatting Signed-off-by: Shriram Rajagopalan <[email protected]> * vendor update Signed-off-by: Shriram Rajagopalan <[email protected]> * lint Signed-off-by: Shriram Rajagopalan <[email protected]> * build fixes Signed-off-by: Shriram Rajagopalan <[email protected]> * undos Signed-off-by: Shriram Rajagopalan <[email protected]> * lint Signed-off-by: Shriram Rajagopalan <[email protected]> * nits Signed-off-by: Shriram Rajagopalan <[email protected]> * test fix Signed-off-by: Shriram Rajagopalan <[email protected]> * validation Signed-off-by: Shriram Rajagopalan <[email protected]> * format Signed-off-by: Shriram Rajagopalan <[email protected]> * comments Signed-off-by: Shriram Rajagopalan <[email protected]> * format Signed-off-by: Shriram Rajagopalan <[email protected]> * new crd yaml Signed-off-by: Shriram Rajagopalan <[email protected]> * nix listener port Signed-off-by: Shriram Rajagopalan <[email protected]> * kubernetes hack for parsing namespace Signed-off-by: Shriram Rajagopalan <[email protected]> * some code cleanups and more TODOs Signed-off-by: Shriram Rajagopalan <[email protected]> * more undos Signed-off-by: Shriram Rajagopalan <[email protected]> * spell check Signed-off-by: Shriram Rajagopalan <[email protected]> * more nits Signed-off-by: Shriram Rajagopalan <[email protected]> * lint Signed-off-by: Shriram Rajagopalan <[email protected]> * leftovers Signed-off-by: Shriram Rajagopalan <[email protected]> * undo tests * more undos Signed-off-by: Shriram Rajagopalan <[email protected]> * more undos Signed-off-by: Shriram Rajagopalan <[email protected]> * del Signed-off-by: Shriram Rajagopalan <[email protected]> * sidecarproxy Signed-off-by: Shriram Rajagopalan <[email protected]> * format Signed-off-by: Shriram Rajagopalan <[email protected]> * compile fixes Signed-off-by: Shriram Rajagopalan <[email protected]>
* run log Configure before running server and validation * remove p.logConfigure func from patchTable * fix lint * fix rebase error * fix rebase error * fix lint
* Use 128bit traceids in envoy * Update unit test golden files for bootstrap config
* sync with latest istio.io/api This PR syncs to the latest changes from istio.io/api. Notably, this PR includes the enhanced MCP service definitions and protos (ResourceSink and ResourceSource) along with several API cleanups. Minimal changes have been made to fix the build and tests so that subsequent istio.io/api changes can be merged into istio/istio. An additional PR will be introduced to implement the enhanced MCP service layer. * address review comments * remove bad find/replace
…#10879) * Add a newline at the end of a certificate * Fix the mock test * Fix a lint error
* Log additional information about build machine * Attempt to enable IPv4 forwarding * tabs to spaces
* stop mcpclient when mixer stops * fix test
…ow (istio#10887) * add integration test that mTLS through identity provisioned by SDS flow * format
* fix pilot goroutine leak * remove done channel
…stio#10154) * Do not fail envoy health probe if a config was rejected (istio#9786) * Adjust so that rejection is also an allowed state of health probe for envoy. Co-authored-by: Ralf Pannemans <[email protected]> * Add unit tests for envoy health probe Co-authored-by: Ralf Pannemans <[email protected]> * Fixed linting Co-authored-by: Ralf Pannemans <[email protected]> * Fix another linting problem Co-authored-by: Ralf Pannemans <[email protected]> * Add new stats to String() method * Use better wording in log message * Fix linting Co-authored-by: Ulrich Kramer <[email protected]>
* Move everything related to spiffe URIs to package spiffe Co-authored-by: Ulrich Kramer <[email protected]> * Fix end-to-end tests after merge Co-authored-by: Julia Plachetka <[email protected]> * Adapt and fix unit tests. Co-authored-by: Ralf Pannemans <[email protected]> * Adapt and fix unit tests. * Fix lint errors and unit tests * Fix lint errors * Fix lint errors * Fix lint errors. Exit integration test in case of nonexisting secret * Remove duplicate trustDomain * Fixed compile errors * Fixed lint errors * Fixed lint errors * Do not panic and small fixes * Do not panic when spiffe uri is missing some configuration values * Remove environment variable ISTIO_SA_DOMAIN_CANONICAL * Fix SNA typo * Comment why testing for a kube registry Co-authored-by: Holger Oehm <[email protected]> * goimports-ed Co-authored-by: Holger Oehm <[email protected]> * Adapt test to getSpiffeId no longer panicing Co-authored-by: Holger Oehm <[email protected]> * Fix formatting Co-authored-by: Holger Oehm <[email protected]> * Fix lint errors and unit tests Co-authored-by: Holger Oehm <[email protected]> * Fix double declared imports Co-authored-by: Ralf Pannemans <[email protected]> * Fix more import related linting Co-authored-by: Ralf Pannemans <[email protected]>
* Add retry to metrics check in TestTcpMetrics * Small cleanup * Fix typo
…#10889) * Fix New Test Framework tests running in kubernetes environment After the change istio#10562 Istio Deployment in new test framework started failing. This PR tries to fix that * Minor fix
* Add Pod and Node sources to Galley. Also plumbing annotations and labels through from the source. * adding access for pods/nodes to deployment. * plumbing labels/annotations through Pilot
Signed-off-by: Kuat Yessenov <[email protected]>
- rebased on release-1.1
Partially addresses istio#7665.
* Reduce flakiness in metrics test in new test framework * Fix based on review
istio-testing
requested review from
GregHanson,
ZackButcher,
ayj,
cmluciano,
costinm,
diemtvu,
geeknoid,
mandarjog,
nmittler,
ostromart,
ozevren,
qiwzhang,
rshriram and
yangminzhu
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hklai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
googlebot
added
the
cla: no
Contributor
Author
|
/test istio-unit-tests |
Collaborator
|
@hklai: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
hklai
added
cla: yes
and removed
cla: no
Collaborator
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.