Skip to content

Update the SHA of istio-proxy#10618

Closed
lei-tang wants to merge 1 commit intoistio:release-1.1from
lei-tang:update-istio-proxy-sha-release-1.1
Closed

Update the SHA of istio-proxy#10618
lei-tang wants to merge 1 commit intoistio:release-1.1from
lei-tang:update-istio-proxy-sha-release-1.1

Conversation

@lei-tang
Copy link
Copy Markdown
Contributor

Update the SHA of istio-proxy; the original SHA is 20 days ago.

Update the SHA of istio-proxy; the original SHA is 20 days ago.
@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lei-tang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid

If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-unit-tests.sh 90b6c4f link /test istio-unit-tests
prow/istio-presubmit.sh 90b6c4f link /test istio-presubmit
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang
Copy link
Copy Markdown
Contributor Author

/assign @geeknoid

@stale
Copy link
Copy Markdown

stale bot commented Jan 4, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label Jan 4, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

@lei-tang: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jan 18, 2019
@stale stale bot removed the stale label Jan 18, 2019
@stale
Copy link
Copy Markdown

stale bot commented Feb 4, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label Feb 4, 2019
@stale
Copy link
Copy Markdown

stale bot commented Mar 6, 2019

This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot closed this Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR needs to be rebased before being merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants