Skip to content

Implement conversion Integration tests for Galley#10473

Merged
istio-testing merged 13 commits intoistio:release-1.1from
ozevren:gl1
Dec 14, 2018
Merged

Implement conversion Integration tests for Galley#10473
istio-testing merged 13 commits intoistio:release-1.1from
ozevren:gl1

Conversation

@ozevren
Copy link
Copy Markdown
Contributor

@ozevren ozevren commented Dec 13, 2018 •
edited
Loading

Implements the conversion integration test for Galley.

Moves current validation tests that are at the "galley/" to a lower level folder at "galley/validation" for better test refactoring.
Implement a conversion test based on an input-output golden file model that tests Galley's MCP output, based on K8s resource inputs in YAML form.
Make Galley Server restartable. This is done by making the event registration restartable as well.
Add a new local-only Galley component in the new test framework.
Fix Makefile issue that causes test.integration.* targets to shadow test.integration.*.kube targets.
Introduce an in-memory mcp/client/Updater implementation for testing.

ozben added 13 commits December 13, 2018 13:55
Move Galley validation integration test to its own folder.
799d16b
Introduce Galley conversion integration tests.
5830a97 
- Implement a conversion test based on an input-output golden file
model that tests Galley's MCP output, based on K8s resource inputs in
YAML form.
- Make Galley Server restartable. This is done by making the event
registration restartable as well.
- Add a new local-only Galley component in the new test framework.
- Fix Makefile issue that causes test.integration.* targets to shadow
test.integration.*.kube targets.
- Introduce an in-memory mcp/client/Updater implementation for testing.
Cleanup.
dea167e
make format
6aa5078
Fix lint issues.
abb0145
Add missing close method.
a3ffcfb
Try to appease Lint gods.
f14381f
One more sacrifice.
c3a6f9c
Accommodate CR comments.
87c7868
Try to fix linter problem #1.
322b1da
linter fixes.
7362d06
"Fix" lint issue.
de4d1a3
"Fix" lint issue.
322f9a5
@ozevren ozevren requested review from ayj, hklai and nmittler December 13, 2018 22:07
@ozevren
Copy link
Copy Markdown
Contributor Author

ozevren commented Dec 13, 2018

Same as #10381. Recreated a new PR to for 1.1 branch.

@ozevren
Copy link
Copy Markdown
Contributor Author

ozevren commented Dec 14, 2018

Friendly ping on this. This is the same PR that was reviewed against the master branch, just rebased on 1.1.
I'd like to build on this.

@geeknoid
Copy link
Copy Markdown
Contributor

geeknoid commented Dec 14, 2018

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Dec 14, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geeknoid, ozevren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Dec 14, 2018

@ozevren: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-simpleTests-minProfile.sh 322f9a5 link /test e2e-simpleTestsMinProfile
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing merged commit 61c571b into istio:release-1.1 Dec 14, 2018
rshriram added a commit that referenced this pull request Dec 14, 2018
@rshriram
Revert "Implement conversion Integration tests for Galley (#10473)"
b0c4a89 
This reverts commit 61c571b.
istio-testing pushed a commit that referenced this pull request Dec 15, 2018
@rshriram @istio-testing
Revert "add mixerRouteConfig cache" (#10496)
43c73aa 
* Revert "Implement conversion Integration tests for Galley (#10473)"

This reverts commit 61c571b.

* Revert "Update codecov check to skip deleted files (#10436)"

This reverts commit 78bd62e.

* Revert "add mixerRouteConfig cache (#10292)"

This reverts commit 39aea94.
@ozevren ozevren deleted the gl1 branch August 23, 2019 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayj ayj Awaiting requested review from ayj

@nmittler nmittler Awaiting requested review from nmittler

@hklai hklai Awaiting requested review from hklai

Assignees

@geeknoid geeknoid

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ozevren @geeknoid @istio-testing @googlebot