Skip to content

Multiple addresses of a ServiceEntry get lost in conversion to model.Service #5498

@vadimeisenbergibm

Description

@vadimeisenbergibm

There is a mismatch between the pilot model of a Service with a single Address or a map of Addresses, an address per cluster, https://github.com/istio/istio/blob/release-0.8/pilot/pkg/model/service.go#L53, and the definition of the ServiceEntry https://github.com/istio/api/blob/master/networking/v1alpha3/service_entry.proto#L170.

Currently, a model.Service is built from each address of ServiceEntry.

A possible renaming: rename model's Addresses into ClusterAddresses, and Address into Addresses. Then take the Addresses into account in the code that builds tcp proxy filters - https://github.com/istio/istio/blob/release-0.8/pilot/pkg/networking/core/v1alpha3/listener.go#L381 .

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions