@@ -13,7 +13,6 @@ issues and merge pull requests (PRs).
1313 - [ Holds] ( #holds )
1414- [ Project maintainers] ( #project-maintainers )
1515- [ Merging PRs] ( #merging-prs )
16- - [ Merge hours] ( #merge-hours )
1716
1817## Pull requests welcome
1918
@@ -30,17 +29,6 @@ community will also be active reviewers. We ask that active contributors to
3029the project participate in the code review process in areas where that
3130contributor has expertise.
3231
33- Active contributors are considered to be anyone who meets any of the following
34- criteria:
35- * Sent more than two pull requests (PRs) in the previous one month, or more
36- than 20 PRs in the previous year.
37- * Filed more than three issues in the previous month, or more than 30 issues
38- in the previous 12 months.
39- * Commented on more than 5 pull requests in the previous month, or
40- more than 50 pull requests in the previous 12 months.
41- * Marked any PR as LGTM in the previous month.
42- * Have * collaborator* permissions in the respective repository.
43-
4432## Reviewing changes
4533
4634Once a PR has been submitted, reviewers should attempt to do an initial review
@@ -110,29 +98,3 @@ PRs may only be merged after the following criteria are met:
110981 . It has been ` LGTM ` -ed by at least one of the maintainers listed in
11199 the OWNERS file for that repository.
1121001 . It has all appropriate corresponding documentation and tests.
113-
114- ### Merge hours
115-
116- Maintainers will do merges of appropriately reviewed-and-approved changes during
117- their local "business hours" (typically 7:00 am Monday to 5:00 pm (17:00h)
118- Friday). PRs that arrive over the weekend or on holidays will only be merged if
119- there is a very good reason for it and if the code review requirements have been
120- met. Concretely this means that nobody should merge changes immediately before
121- going to bed for the night.
122-
123- There may be discussion and even approvals granted outside of the above hours,
124- but merges will generally be deferred.
125-
126- If a PR is considered complex or controversial, the merge of that PR should be
127- delayed to give all interested parties in all timezones the opportunity to
128- provide feedback. Concretely, this means that such PRs should be held for 24
129- hours before merging. Of course "complex" and "controversial" are left to the
130- judgment of the people involved, but we trust that part of being a committer is
131- the judgment required to evaluate such things honestly, and not be motivated by
132- your desire (or your cube-mate's desire) to get their code merged. Any reviewer
133- can issue a [ "hold"] ( #holds ) to indicate that the PR is in fact complicated
134- or complex and deserves further review.
135-
136- PRs that are incorrectly judged to be merge-able, may be reverted and subject to
137- re-review, if subsequent reviewers believe that they in fact are controversial
138- or complex.
0 commit comments