Conversation
It is no longer needed since Api::Api is plumbed ubiquitiously throughout Envoy's core. The only user of the factory, QuicThreadImpl, has been modified to take the Envoy::Thread::ThreadFactory via QuicThreadImpl::setThreadFactory(). Signed-off-by: Andres Guedez <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
This PR moves the xds protocol from md to rst. Risk Level: Low Testing: N/A Docs Changes: N/A Release Notes: N/A Fixes envoyproxy#6338 Signed-off-by: Rama Chavali <[email protected]>
…oxy#6504) * Adds SharedStatNameStorageSet. Signed-off-by: Joshua Marantz <[email protected]>
…voyproxy#6657) A couple of the proto descriptors validated during startup are specific to extensions that may be compiled out. This change only validates their presence when the extensions are used. This fixes some spurious validation failures in certain minimal build configurations. Risk Level: Low Testing: Ran test suite, ran server. Docs Changes: N/A Release Notes: N/A Signed-off-by: Mike Schore <[email protected]>
Change name of class TestHooks to ListenerHooks Risk Level: Low; name change only. Testing: Existing tests Docs Changes: n/a Release Notes: n/a Fixes envoyproxy#6641 Signed-off-by: Randy Smith <[email protected]>
…oyproxy#6648) Signed-off-by: Matt Klein <[email protected]>
…oxy#6672) Improve build rules for (test only) library quic_port_utils, by removing the intermediate library //extensions/quic_listeners/quiche/platform:quic_platform_port_utils_impl_lib. Risk Level: none, build only Testing: bazel test --test_output=all test/extensions/quic_listeners/quiche/platform:all @com_googlesource_quiche//:all bazel test --test_output=all --define quiche=enabled test/extensions/quic_listeners/quiche/platform:all @com_googlesource_quiche//:all Signed-off-by: Bin Wu <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
Reintroduce dispatcher stats previously reverted in envoyproxy#6649. Dispatcher stats are now gated on a new bootstrap config parameter, enable_dispatcher_stats, and disabled by default. Risk Level: Low Testing: Manually verified that config is respected (see envoyproxy#6582, this still requires integration tests). Docs Changes: Included a note about how statsd doesn't play well with these high-volume histograms. Signed-off-by: Dan Rosen <[email protected]>
Signed-off-by: Derek Schaller <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Andres Guedez <[email protected]>
Signed-off-by: Derek Schaller <[email protected]>
The PR (envoyproxy#6384) for the enhancement to jwt_authn was accepted before 1.10.0 was cut, and so the history was edited with 1.10.0 in mind, but the merge of happened just after 1.10.0 was cut. Therefore, this change moves the jwt_authn line from the "1.10.0 (April 5, 2019)" section to the "1.11.0 (Pending)" section. Signed-off-by: Larry West <[email protected]>
…oxy#6583) Signed-off-by: Brian Rectanus <[email protected]>
* docs: add extension policy Signed-off-by: Derek Schaller <[email protected]>
envoyproxy#6610) * build: bump rules_foreign_cc to e3f4b5e0 and switch to lld for .bazelrc sanitizers. This allows for all --copt/--cxxopt/--linkopt to be plumbed to external dependencies. Risk level: Low Testing: CI Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Derek Schaller <[email protected]>
…ons. (envoyproxy#6688) Per @ambuc's comment on envoyproxy#6161 I think it would be better to keep a log of the memory consumed by stats, and also use exact comparisons. That way we can get historical perspective into the relative impact of adding new stats or families of stats. Risk Level: low, but could cause more changes to this one test. Testing: just this one test. Docs Changes: n/a Release Notes: n/a Signed-off-by: Joshua Marantz <[email protected]>
Parameterizes existing fuzzer to yield a second fuzzer than can independently fuzz the new implementation. Risk level: Low Testing: bazel test //test/common/buffer/... Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Dan Rosen <[email protected]>
Dynamic link tests in ASAN to save disk space. Partially addresses envoyproxy#1407. Risk Level: Low (ASAN only) Testing: CI Signed-off-by: Lizan Zhou <[email protected]>
…oxy#6705) Change the type of data_storage_ from std::map to absl::flat_hash_map which is unordered map and supports heterogeneous lookup natively. Cleanup absl::string_view to std::string conversion in the cc file. Risk Level: Low Testing: unit test Signed-off-by: Kyu Chang <[email protected]>
…oyproxy#6697) Description: `absl::SimpleAtoi` takes `absl::string_view` argument and can easily replace all of the calls to `StringUtil::atoull` that are using Base 10 conversion. This eliminates a significant number of places where a `std::string` needed to be constructed from `string_view` to obtain a C string for `StringUtil:atoull`. Risk Level: Low Testing: `bazel test //test/...` Docs Changes: N/A Release Notes: N/A Part of: Issue envoyproxy#6580 Signed-off-by: Dan Noé <[email protected]>
…xy#6693) Move the following QUIC testonly platform libraries to //test: * quic_expect_bug_impl * quic_mock_log_impl * quic_test_impl * quic_test_output_impl Risk Level: none, only moved unused code. Testing: bazel test --test_output=all test/extensions/quic_listeners/quiche/platform:all @com_googlesource_quiche//:all Signed-off-by: Bin Wu <[email protected]>
…oxy#6707) Description: absl::SimpleAtoi takes absl::string_view argument and can replace all of the calls to StringUtil::atoll that are using Base 10 conversion, which turns out to be all of them. This PR removes StringUtil::atoll entirely and migrates all callers to absl::SimpleAtoi. Risk Level: Low Testing: bazel test //test/... Docs Changes: N/A Release Notes: N/A Part of: Issue envoyproxy#6580 Signed-off-by: Dan Noé <[email protected]>
…roxy#6710) And remove explicit string construction from gzip filter usage. Signed-off-by: Dan Noé <[email protected]>
Previously if an EDS cluster was using active health checking, a host would only be removed if it was removed both from EDS as well as failed active HC. This change allows a host to be removed if it is first failed by EDS, and then removed by EDS. This provides a management server a mechanism to force removal of a host even when the host may still be passing active health checking. Signed-off-by: Matt Klein <[email protected]>
It's helpful to a client-side LB to know the total endpoint serving QPS when making LB decisions. This could also be used as a signal for Envoy's least loaded LB. Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
Implements the hedge_on_per_try_timeout option in HedgePolicy config which instructs the router filter to not cancel requests that hit the per try timeout before sending a retry. This means the router must be able to manage multiple simultaneous upstream requests and handle deciding which response "wins" and canceling any other in flight requests. Fixes envoyproxy#5841 Signed-off-by: Michael Puncel <[email protected]>
Signed-off-by: Mitch Sukalski <[email protected]>
…uzzer (envoyproxy#7070) Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=14779 Risk level: Low Testing: Corpus entry added. Signed-off-by: Asra Ali <[email protected]>
Signed-off-by: Taylor Barrella <[email protected]>
Signed-off-by: Derek Argueta <[email protected]>
Signed-off-by: zzg <[email protected]>
…he route level (envoyproxy#6986) Signed-off-by: Gary Brown <[email protected]>
Signed-off-by: Jyoti Mahapatra <[email protected]>
…nvoyproxy#7079) * Make the new buffer impl's reserve/commit semantics match libevent * On OwnedImpl::reserve, if any slices at the end of the buffer have reservations, clear the reservations so the space can be used for the new reservation. * Add tests for the two cases where this is important: calling reserve and never committing the buffers before the next reserve call; and calling reserve, getting back N slices, and only committing the first M of those slices (where M < N) before the next reserve call. Signed-off-by: Brian Pane <[email protected]>
…tion time. (envoyproxy#7046) Signed-off-by: Joshua Marantz <[email protected]>
This seems to have changed (and SHA256) on GH, from 1.5 -> 1.5.0. I will also followup internally on this. Risk level: Low Testing: bazel test //test/common/upstream:load_balancer_benchmark Signed-off-by: Harvey Tuch <[email protected]>
Another .h split enabled by xDS detemplatization. (Followup to envoyproxy#6391) Risk Level: none Signed-off-by: Fred Douglas <[email protected]>
Implement QuicClock using Event::TimeSystem. Currently implement ApproximateNow() as Now() because TimeSystem doesn't support approximate time. Risk Level: low, not in use Testing: added test/extentions/quic_listeners/quiche/platform:envoy_quic_clock_test Part of envoyproxy#2557 Signed-off-by: Dan Zhang <[email protected]>
Signed-off-by: Fred Douglas <[email protected]>
… code (envoyproxy#7088) Adds header string filter on cookie headers to fix crashing fuzz tests. Removes dead hasSetCookie code, and associated tests and fuzz tests. Fixes oss-fuzz issue https://oss-fuzz.com/testcase-detail/5735325211557888 Risk Level: Low. Testing: Corpus entry added for crashing input. Signed-off-by: Asra Ali <[email protected]>
…oyproxy#7037) Add an RAII helper class that adds an element to a list on construction and removes it on destruction. Risk Level: low Testing: unit tests Fixes: envoyproxy#7020 Signed-off-by: Elisha Ziskind <[email protected]>
* ci: add make_unique rule to check_format Signed-off-by: Yuchen Dai <[email protected]>
Add an http filter to extract the original source on a per-http-request basis Signed-off-by: Kyle Larose <[email protected]>
Signed-off-by: Elisha Ziskind <[email protected]>
…or in libstdc+++ (envoyproxy#7099) With libstdc++ the the std::tuple constructor picked by a {x,y,z} parameter is "explicit tuple(TP_&&...) ", which causes a compilation error, remove the usage of std::tuple to make the test code more compatible w/ libstdc++. Risk Level: LOW Testing: Unit test. Signed-off-by: Xin Zhuang <[email protected]>
Signed-off-by: John Plevyak <[email protected]>
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
Signed-off-by: Alyssa Wilk <[email protected]>
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]