Skip to content

Update protobuf exception #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
istio-testing merged 2 commits into from
Jul 21, 2022
Merged

Update protobuf exception #633

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb96460
Update protobuf exception
howardjohn Jul 18, 2022
8d98982
Update .golangci.yml
howardjohn Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions files/common/config/.golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,13 @@ issues:
- errcheck
- maligned

# TODO(https://github.com/dominikh/go-tools/issues/732) remove this once we update
# We need to use the deprecated module since the jsonpb replacement is not backwards compatible.
- linters:
- staticcheck
text: "SA1019: package github.com/golang/protobuf"
text: "SA1019: package github.com/golang/protobuf/jsonpb"
- linters:
- staticcheck
text: 'SA1019: "github.com/golang/protobuf/jsonpb"'

# Independently from option `exclude` we use default exclude patterns,
# it can be disabled by this option. To list all
Expand Down