Skip to content

API changes to enable TCP keepalive configuration.#715

Closed
shakti-das wants to merge 1 commit intoistio:masterfrom
shakti-das:shakti/tcp-keepalive
Closed

API changes to enable TCP keepalive configuration.#715
shakti-das wants to merge 1 commit intoistio:masterfrom
shakti-das:shakti/tcp-keepalive

Conversation

@shakti-das
Copy link
Copy Markdown
Member

@shakti-das shakti-das commented Nov 20, 2018 •
edited
Loading

API changes PR for istio/istio#9378

Signed-off-by: Shakti [email protected]

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 20, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Nov 20, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shakti-das
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm

If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Nov 20, 2018

Hi @shakti-das. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hzxuzhonghu
hzxuzhonghu reviewed Nov 21, 2018
View reviewed changes
networking/v1alpha3/destination_rule.proto
message TCPSettings {
// TCP keepalive.
message TcpKeepalive {
// TCP keepalive time.
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expect a more detailed description, like envoy doc The number of seconds a connection needs to be idle before keep-alive probes start being sent. Default is to use the OS level configuration (unless overridden, Linux defaults to 7200s (ie 2 hours.)

Copy link
Copy Markdown
Member Author

@shakti-das shakti-das Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add more details.

hzxuzhonghu
hzxuzhonghu reviewed Nov 21, 2018
View reviewed changes
networking/v1alpha3/destination_rule.proto
// TCP keepalive.
message TcpKeepalive {
// TCP keepalive time.
google.protobuf.Duration time = 1;
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt this should not be Duration type.

https://github.com/envoyproxy/data-plane-api/blob/4619dc3f6246465a924cd3a19e3089ff0942e9be/envoy/api/v2/core/address.proto#L65-L77

Copy link
Copy Markdown
Member Author

@shakti-das shakti-das Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt the goal is to keep the same proto definition. I read in one of the PR review comments that the set of configuration options need to be added as required. Looking at the discussion in the linked issue, it seems we want to expose keepalive time and interval at the moment.

Regarding the Duration fields, considering it's a time related field, instead of specifying it as uint and mentioning in comments that the unit is seconds, I felt it's better to keep it as duration in Istio proto. In the impl, we can easily convert duration to seconds while populating Envoy proto fields.

Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

istio/istio#9378 (comment)
Cloud Foundry operators have requested support for control of TCP keepalive probe count and interval.

Copy link
Copy Markdown
Member Author

@shakti-das shakti-das Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the reference, will add probes to the PR.

hzxuzhonghu
hzxuzhonghu reviewed Nov 21, 2018
View reviewed changes
networking/v1alpha3/destination_rule.proto
google.protobuf.Duration time = 1;

// TCP keepalive interval.
google.protobuf.Duration interval = 2;
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here type mismatch

@hzxuzhonghu
Copy link
Copy Markdown
Member

hzxuzhonghu commented Nov 21, 2018

I think we also need an additional field to set keepalive_probes

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Nov 21, 2018

  1. to release-1.1 branch
  2. The issue asks for Mesh level configuration while what you are doing here is at DestinationRule level
    Granted that you can define a Global DestinationRule, but it will get overwritten when someone declares something local. Does it make sense to move this to mesh/config.proto (its a bit of a kitchen sink right now). I don't mind having this in the DestinationRule (in fact we should have it there in addition to mesh config I guess).

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Nov 21, 2018

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 21, 2018
@shakti-das
Copy link
Copy Markdown
Member Author

shakti-das commented Nov 21, 2018

  1. Will send PR to 1.1 branch.
  2. Will add it to MeshConfig + DestinationRule. Implementation will then have following defaulting behavior:
    DestinationRule (if set, else next) > MeshConfig (if set, else next) > OS default (skip the envoy config)

@shakti-das
Copy link
Copy Markdown
Member Author

shakti-das commented Nov 21, 2018

The review comments are addressed in PR #718 which is for release-1.1 branch.

@shakti-das shakti-das mentioned this pull request Nov 22, 2018
Merged
@rshriram rshriram closed this Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu left review comments

@costinm costinm Awaiting requested review from costinm

@rshriram rshriram Awaiting requested review from rshriram

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shakti-das @istio-testing @hzxuzhonghu @rshriram @googlebot