Updating description of network definitions#664
Conversation
Signed-off-by: Shriram Rajagopalan <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
googlebot
added
the
cla: yes
mesh/v1alpha1/network.proto
Outdated
| repeated string registries = 2; | ||
| message NetworkEndpoints { | ||
| oneof ne { | ||
| // A CIDR range for the set of endpoints in this network |
There was a problem hiding this comment.
Few more words here ? It assumes the endpoints in the mesh have non-overlapping CIDR ranges ?
An endpoint will be assigned to a network:
- directly by the registry, if it can infer the network from its backends
- by matching the registry name with one of the "from_registries" in the mesh config. A "from_registry" can only be assinged to a single network.
- by matching the IP against one of the CIDR ranges in a mesh config network. The CIDR ranges must not overlap and be assigned to a single network.
There was a problem hiding this comment.
by matching the registry name with one of the "from_registries" in the mesh config. A "from_registry" can only be assinged to a single network.
@costinm What do you mean by from_registries? I can not find it.
Signed-off-by: Shriram Rajagopalan <[email protected]>
* clarity Signed-off-by: Shriram Rajagopalan <[email protected]> * renaming * nits Signed-off-by: Shriram Rajagopalan <[email protected]>
* clarity Signed-off-by: Shriram Rajagopalan <[email protected]> * renaming * nits Signed-off-by: Shriram Rajagopalan <[email protected]>
* Updating description of network definitions (#664) * clarity Signed-off-by: Shriram Rajagopalan <[email protected]> * renaming * nits Signed-off-by: Shriram Rajagopalan <[email protected]> * Added MeshNetworks
| // The names of the registries should correspond to the secret name | ||
| // that was used to configure the registry (kubernetes multicluster) or | ||
| // supplied by MCP server. | ||
| string from_registry = 2; |
There was a problem hiding this comment.
can you explain how this can be used? I am still confused after through the istio code.
6 participants
Signed-off-by: Shriram Rajagopalan [email protected]