Merged
Conversation
googlebot
added
the
cla: yes
rshriram
approved these changes
Feb 16, 2018
Makefile
Outdated
| mixer_adapter_model_v1beta_pb_gos := $(mixer_adapter_model_v1beta_protos:.proto=.pb.go) | ||
| mixer_adapter_model_v1beta_pb_doc := $(mixer_adapter_model_v1beta_path)/istio.mixer.adapter.model.v1beta.pb.html | ||
|
|
||
| policy_v1beta_path := policy/v1beta |
policy/v1beta/cfg.proto
Outdated
| @@ -0,0 +1,214 @@ | |||
| // Copyright 2016 Istio Authors | |||
Member
There was a problem hiding this comment.
2018
Also can we use this opportunity to name this file to something more seo friendly ? I believe this is a key piece of mixer reference docs. So it could use a more friendly name.
geeknoid
reviewed
Feb 16, 2018
Contributor
geeknoid
left a comment
geeknoid
left a comment
There was a problem hiding this comment.
Let's use v1beta1 for consistency with the standard pattern.
Do the same for mixer/adapter/model too.
geeknoid
approved these changes
Feb 17, 2018
Member
|
I'm trying to see how that should reflect in |
ldemailly
added a commit
to istio/istio
that referenced
this pull request
Feb 18, 2018
istio/old_vendor-istio_repo#2 is merged Ran dep ensure A bit surprised the api SHA change didn’t trigger any file change istio/api#376 (comment)
Member
|
I think I know why: it's pruned / not used yet We should change the bot a bit to also update vendor and the config to not prune istio.io/api |
ldemailly
added a commit
to istio/istio
that referenced
this pull request
Feb 18, 2018
* vendor_update_Feb17_2018 Ran dep ensure —update Also bump up fortio version Fixes #3585 * Update to head istio/old_vendor-istio_repo#2 is merged Ran dep ensure A bit surprised the api SHA change didn’t trigger any file change istio/api#376 (comment)
xiaolanz
reviewed
Feb 18, 2018
policy/v1beta/cfg.proto
Outdated
| // $front_matter: redirect_from: /docs/reference/policy/policy-and-telemetry-rules.html | ||
|
|
||
| // Describes the rules used to configure Mixer's policy and telemetry features. | ||
| package istio.policy.v1beta; |
Contributor
There was a problem hiding this comment.
why it's not v1beta1? no plan to make incompatible changes in beta?
Contributor
Author
|
Hi Joy,
This has been now fixed
https://github.com/istio/api/blob/master/policy/v1beta1/cfg.proto#L26
…On Sun, Feb 18, 2018 at 1:47 PM Joy Zhang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In policy/v1beta/cfg.proto
<#376 (comment)>:
> +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+syntax = "proto3";
+
+import "google/protobuf/struct.proto";
+import "policy/v1beta/value_type.proto";
+
+// $title: Policy and Telemetry Rules
+// $overview: Describes the rules used to configure Mixer's policy and telemetry features.
+// $location: https://istio.io/docs/reference/policy/istio.policy.v1beta.html
+// $front_matter: redirect_from: /docs/reference/policy/policy-and-telemetry-rules.html
+
+// Describes the rules used to configure Mixer's policy and telemetry features.
+package istio.policy.v1beta;
why it's not v1beta1? no plan to make incompatible changes in beta?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#376 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AK6xEzeFAi5ObDomt-UMg9SbdKg25lRnks5tWJpigaJpZM4SHzDe>
.
--
*Thanks,*
*-SG*
|
Contributor
|
Yes. it looks great. If we plan to move CRDs any time soon, please coordinate with @cmluciano |
incfly
pushed a commit
to incfly/api
that referenced
this pull request
Jun 13, 2018
nacx
pushed a commit
to nacx/api
that referenced
this pull request
Feb 23, 2022
Signed-off-by: Dhi Aurrahman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$comments for docgen.