Skip to content

TracingProviders: Add Dynatrace trace provider#3003

Closed
joaopgrassi wants to merge 1 commit intoistio:masterfrom
dynatrace-oss-contrib:dynatrace-trace-provider
Closed

TracingProviders: Add Dynatrace trace provider#3003
joaopgrassi wants to merge 1 commit intoistio:masterfrom
dynatrace-oss-contrib:dynatrace-trace-provider

Conversation

@joaopgrassi
Copy link
Copy Markdown
Member

@joaopgrassi joaopgrassi commented Nov 27, 2023

In #47453 I proposed to add a new tracing provider in Istio for Dynatrace. The idea was to add a provider for Dynatrace that "wraps" the OpenTelemetry one in Istio, offering easy of configuration to our customers.

The community opinion was that this was not a good idea as there's a desire to decrease vendor code in MeshConfig. It was advised to simply instruct users to use the OTel provider already available today.

I opened now initial PRs to extend the OTel provider in Istio to support the new Envoy features #3002. The goal of this PR is to offer a comparison to the community of how much config going with a Dynatrace extension would be compared to extending the OpenTelemetry one. Mainly for the concern of adding more things to MeshConfig. This route is much simpler, with the caveat that it's custom tailored to Dynatrace users, whereas the one in #3002 can benefit everyone.

@joaopgrassi joaopgrassi requested a review from a team as a code owner November 27, 2023 10:43
@joaopgrassi joaopgrassi marked this pull request as draft November 27, 2023 10:43
@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Nov 27, 2023
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @joaopgrassi. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joaopgrassi joaopgrassi marked this pull request as ready for review January 24, 2024 10:25
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 24, 2024
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jan 25, 2024
@istio-testing
Copy link
Copy Markdown
Collaborator

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@linsun
Copy link
Copy Markdown
Member

linsun commented Jan 25, 2024

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 25, 2024
@hzxuzhonghu
Copy link
Copy Markdown
Member

Instead of adding more and more providers, it seems OTEL is the generic way to do

@zirain
Copy link
Copy Markdown
Member

zirain commented Jan 27, 2024

#2998 merged, can we close this? cc @joaopgrassi

@joaopgrassi
Copy link
Copy Markdown
Member Author

@zirain yes I believe the direction is to add the opentelemetry configuration and not vendor specific. I will close this. Thanks!

@joaopgrassi joaopgrassi deleted the dynatrace-trace-provider branch February 5, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR needs to be rebased before being merged ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants