Skip to content

Commit 001174f

Browse files
author
mtail
committed
Comment fixes.
1 parent 5762965 commit 001174f

File tree

5 files changed

+37
-37
lines changed

5 files changed

+37
-37
lines changed

‎networking/v1alpha3/istio.networking.v1alpha3.pb.html‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -266,12 +266,12 @@ <h2 id="CorsPolicy">CorsPolicy</h2>
266266
<section>
267267
<p>Describes the Cross-Origin Resource Sharing (CORS) policy, for a given
268268
service. Refer to
269-
https://developer.mozilla.org/en-US/docs/Web/HTTP/Access<em>control</em>CORS
269+
<a href="https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS">https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS</a>
270270
for further details about cross origin resource sharing. For example,
271271
the following rule restricts cross origin requests to those originating
272272
from example.com domain using HTTP POST/GET, and sets the
273-
Access-Control-Allow-Credentials header to false. In addition, it only
274-
exposes X-Foo-bar header and sets an expiry period of 1 day.</p>
273+
<code>Access-Control-Allow-Credentials</code> header to false. In addition, it only
274+
exposes <code>X-Foo-bar</code> header and sets an expiry period of 1 day.</p>
275275

276276
<pre><code class="language-yaml">apiVersion: networking.istio.io/v1alpha3
277277
kind: VirtualService
@@ -348,7 +348,7 @@ <h2 id="CorsPolicy">CorsPolicy</h2>
348348
<td><code><a href="https://developers.google.com/protocol-buffers/docs/reference/google.protobuf#duration">google.protobuf.Duration</a></code></td>
349349
<td>
350350
<p>Specifies how long the results of a preflight request can be
351-
cached. Translates to the Access-Control-Max-Age header.</p>
351+
cached. Translates to the <code>Access-Control-Max-Age</code> header.</p>
352352

353353
</td>
354354
</tr>
@@ -358,7 +358,7 @@ <h2 id="CorsPolicy">CorsPolicy</h2>
358358
<td>
359359
<p>Indicates whether the caller is allowed to send the actual request
360360
(not the preflight) using credentials. Translates to
361-
Access-Control-Allow-Credentials header.</p>
361+
<code>Access-Control-Allow-Credentials</code> header.</p>
362362

363363
</td>
364364
</tr>
@@ -1694,8 +1694,8 @@ <h2 id="HTTPRetry">HTTPRetry</h2>
16941694
<p>Specifies the conditions under which retry takes place.
16951695
One or more policies can be specified using a ‘,’ delimited list.
16961696
The supported policies can be found in
1697-
&ldquo;https://www.envoyproxy.io/docs/envoy/latest/configuration/http<em>filters/router</em>filter#x-envoy-retry-on&rdquo;
1698-
and &ldquo;https://www.envoyproxy.io/docs/envoy/latest/configuration/http<em>filters/router</em>filter#x-envoy-retry-grpc-on&rdquo;</p>
1697+
<a href="https://www.envoyproxy.io/docs/envoy/latest/configuration/http_filters/router_filter#x-envoy-retry-on">https://www.envoyproxy.io/docs/envoy/latest/configuration/http_filters/router_filter#x-envoy-retry-on</a>
1698+
and <a href="https://www.envoyproxy.io/docs/envoy/latest/configuration/http_filters/router_filter#x-envoy-retry-grpc-on">https://www.envoyproxy.io/docs/envoy/latest/configuration/http_filters/router_filter#x-envoy-retry-grpc-on</a></p>
16991699

17001700
</td>
17011701
</tr>
@@ -3300,7 +3300,7 @@ <h2 id="ServiceEntry">ServiceEntry</h2>
33003300
- address: unix:///var/run/example/socket
33013301
</code></pre>
33023302

3303-
<p>For HTTP based services, it is possible to create a VirtualService
3303+
<p>For HTTP-based services, it is possible to create a VirtualService
33043304
backed by multiple DNS addressable endpoints. In such a scenario, the
33053305
application can use the HTTP_PROXY environment variable to transparently
33063306
reroute API calls for the VirtualService to a chosen backend. For
@@ -3333,10 +3333,10 @@ <h2 id="ServiceEntry">ServiceEntry</h2>
33333333
https: 7080
33343334
</code></pre>
33353335

3336-
<p>With HTTP_PROXY=http://localhost/, calls from the application to
3337-
http://foo.bar.com will be load balanced across the three domains
3338-
specified above. In other words, a call to http://foo.bar.com/baz would
3339-
be translated to http://uk.foo.bar.com/baz.</p>
3336+
<p>With <code>HTTP_PROXY=http://localhost/</code>, calls from the application to
3337+
<code>http://foo.bar.com</code> will be load balanced across the three domains
3338+
specified above. In other words, a call to <code>http://foo.bar.com/baz</code> would
3339+
be translated to <code>http://uk.foo.bar.com/baz</code>.</p>
33403340

33413341
<table class="message-fields">
33423342
<thead>

‎networking/v1alpha3/service_entry.pb.go‎

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎networking/v1alpha3/service_entry.proto‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ option go_package = "istio.io/api/networking/v1alpha3";
246246
// - address: unix:///var/run/example/socket
247247
// ```
248248
//
249-
// For HTTP based services, it is possible to create a VirtualService
249+
// For HTTP-based services, it is possible to create a VirtualService
250250
// backed by multiple DNS addressable endpoints. In such a scenario, the
251251
// application can use the HTTP_PROXY environment variable to transparently
252252
// reroute API calls for the VirtualService to a chosen backend. For
@@ -280,10 +280,10 @@ option go_package = "istio.io/api/networking/v1alpha3";
280280
// https: 7080
281281
// ```
282282
//
283-
// With HTTP_PROXY=http://localhost/, calls from the application to
284-
// http://foo.bar.com will be load balanced across the three domains
285-
// specified above. In other words, a call to http://foo.bar.com/baz would
286-
// be translated to http://uk.foo.bar.com/baz.
283+
// With `HTTP_PROXY=http://localhost/`, calls from the application to
284+
// `http://foo.bar.com` will be load balanced across the three domains
285+
// specified above. In other words, a call to `http://foo.bar.com/baz` would
286+
// be translated to `http://uk.foo.bar.com/baz`.
287287
//
288288
message ServiceEntry {
289289
// REQUIRED. The hosts associated with the ServiceEntry. Could be a DNS
@@ -371,7 +371,7 @@ message ServiceEntry {
371371

372372
// REQUIRED: Service discovery mode for the hosts. Care must be taken
373373
// when setting the resolution mode to NONE for a TCP port without
374-
// accompanying IP addresses. In such cases, traffic to any IP on
374+
// accompanying IP addresses. In such cases, traffic to any IP on
375375
// said port will be allowed (i.e. 0.0.0.0:<port>).
376376
Resolution resolution = 5;
377377

‎networking/v1alpha3/virtual_service.pb.go‎

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎networking/v1alpha3/virtual_service.proto‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -908,19 +908,19 @@ message HTTPRetry {
908908
// Specifies the conditions under which retry takes place.
909909
// One or more policies can be specified using a ‘,’ delimited list.
910910
// The supported policies can be found in
911-
// "https://www.envoyproxy.io/docs/envoy/latest/configuration/http_filters/router_filter#x-envoy-retry-on"
912-
// and "https://www.envoyproxy.io/docs/envoy/latest/configuration/http_filters/router_filter#x-envoy-retry-grpc-on"
911+
// <https://www.envoyproxy.io/docs/envoy/latest/configuration/http_filters/router_filter#x-envoy-retry-on>
912+
// and <https://www.envoyproxy.io/docs/envoy/latest/configuration/http_filters/router_filter#x-envoy-retry-grpc-on>
913913
string retry_on = 3;
914914
}
915915

916916
// Describes the Cross-Origin Resource Sharing (CORS) policy, for a given
917917
// service. Refer to
918-
// https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS
918+
// <https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS>
919919
// for further details about cross origin resource sharing. For example,
920920
// the following rule restricts cross origin requests to those originating
921921
// from example.com domain using HTTP POST/GET, and sets the
922-
// Access-Control-Allow-Credentials header to false. In addition, it only
923-
// exposes X-Foo-bar header and sets an expiry period of 1 day.
922+
// `Access-Control-Allow-Credentials` header to false. In addition, it only
923+
// exposes `X-Foo-bar` header and sets an expiry period of 1 day.
924924
//
925925
// ```yaml
926926
// apiVersion: networking.istio.io/v1alpha3
@@ -966,12 +966,12 @@ message CorsPolicy {
966966
repeated string expose_headers = 4;
967967

968968
// Specifies how long the results of a preflight request can be
969-
// cached. Translates to the Access-Control-Max-Age header.
969+
// cached. Translates to the `Access-Control-Max-Age` header.
970970
google.protobuf.Duration max_age = 5;
971971

972972
// Indicates whether the caller is allowed to send the actual request
973973
// (not the preflight) using credentials. Translates to
974-
// Access-Control-Allow-Credentials header.
974+
// `Access-Control-Allow-Credentials` header.
975975
google.protobuf.BoolValue allow_credentials = 6;
976976
}
977977

0 commit comments

Comments
 (0)