Skip to content

Please upgrade source-map to 0.7.2 to get speed improvements #144

Closed

Activity

  1. bcoe commented on Mar 4, 2018

    @bcoe
    Member

    @andreicristianpetcu the new soure-map API is unfortunately async, which would require a fairly major refector of the Istanbul API to support:

    https://github.com/mozilla/source-map/blob/master/CHANGELOG.md#070

    I'm open to help on this front, if you feel like taking a look. I can also look into whether it would be easier to update in nyc first (which has its own implementation of source-map handling).

  2. coreyfarrell commented on Jun 5, 2018

    @coreyfarrell
    Member

    @andreicristianpetcu Just want to mention I've upgraded source-map from 0.5 to 0.6 (in master, not yet released). I didn't try updating to 0.7 because it says that it requires node.js 8 while node.js 6 isn't EOL for another 10 months.

  3. coreyfarrell commented on May 6, 2019

    @coreyfarrell
    Member

    I've looked into this and think it's impossible. nyc needs to process source-map's during process exit hooks where code must be sync. Unless a future version of source-map finds a way to support a sync API we will never be able to upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions