fix: preserve Pako decompression errors when reading objects - #2451

No actionable comments were generated in the recent review. 🎉

Merge Risk: ⚪ Minimal · up to e5b40

No actionable issue remains from this review. The change is mergeable after normal checks.

Pre-merge checks | 4 | 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 14 files. (2 skipped: 2…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly describes the main change: preserving Pako decompression errors while reading objects.

---

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 14 files. (2 skipped: 2 unsupported.)

---

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{A rabbit checks the bytes with care
A stream comes back from frosty air
When headers fail, the errors speak
The tests explore each snowy peak
A new name joins the credits page
Then hops away, content in gauge}

_{Comment @coderabbitai help to get the list of available commands.}

There is a conflict with the list of contributors. Can you resolve it?

Addressed both review findings in d899055.

• Corrupt Pako input now produces a plain Error with the decompression diagnostic, without InternalError's library-bug guidance. The readObject/readTree regressions also check caller attachment in regular repositories and submodules.
• The native path is awaited inside the try block. browserInflate handles asynchronous empty TypeError failures with a nonempty invalid-buffer message and preserves informative Error instances. Native-backend activation remains unchanged.

On Node 22 and Node 24, lint, Rollup, declarations, native JavaScript typecheck and all ten focused suites passed (87 tests and 36 snapshots on each runtime). A contained Chromium smoke test round-tripped binary input and rejected three corrupt streams with nonempty diagnostics. This is focused validation, not a full-suite pass.

The prior contributor-list conflict resolution is retained, and the PR description now reflects the error behavior and current validation.

Addressed the error-hierarchy and native-error comments in e5b405d:

• Added Errors.DecompressionError, a BaseError subclass, for Pako string failures. Its diagnostic, code, data and serialization are covered by regression tests.
• The native path is awaited; asynchronous empty TypeError failures in browserInflate now use the same error type with a nonempty diagnostic. Informative errors retain their identity, and native-backend activation stays unchanged.
• Merged current main and regenerated the contributor table, preserving every upstream contributor.

On this head, Node 22 and 24 each passed lint, Rollup, declarations, JavaScript typechecking and ten focused suites (89 tests, 36 snapshots). The classification regressions fail against the previously published inflation helpers. Chromium smoke checks passed for valid binary data, three corrupt streams and an asynchronous empty native error. The full Node/Chrome suite was not run for this revision.

Renamed the shared helper, module and focused test to nativeInflate in d767f69.

I also reproduced your exact [0, 0] example on Node 22 and 24: DecompressionStream throws a TypeError with an empty message, and nativeInflate reports DecompressionError with Invalid compressed buffer: decompression failed.

On this head, both Node versions passed lint, Rollup, declarations, JavaScript typechecking and ten focused suites (89 tests, 36 snapshots each). Chromium smoke checks passed for valid binary data, three corrupt streams and an asynchronous empty native error. The full Node/Chrome suite was not run for this revision.

I also reproduced your exact [0, 0] example on Node 22 and 24: DecompressionStream throws a TypeError with an empty message, and nativeInflate reports DecompressionError with Invalid compressed buffer: decompression failed.

So could you fix the code?

I've restored the literal Unicode names in .all-contributorsrc; escaping them was an unnecessary formatting change. The parsed contributor data is unchanged, and regenerating the table leaves README.md unchanged.

For [0, 0], the library-side fix is in nativeInflate: it awaits the stream read inside try and converts an empty native TypeError to DecompressionError with the diagnostic decompression failed. The direct platform example still throws the native error; calling the helper on Node 22 and 24 returns DecompressionError with a nonempty message and serialized diagnostic.

c0b935f adds a regression using your actual input, checking the raw failure beside the helper's diagnostic, classification and serialized data. Informative native errors retain their name and message. The updated branch passed lint, build and typechecking, plus 11 focused suites (97 tests and 36 snapshots on each of Node 22 and 24). The full Node/browser suites and a Chromium smoke test were not run for this revision.

🎉 This PR is included in version 1.44.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀