Fix header name in docs/onAuth.md#2225
Merged
jcubic merged 1 commit intoisomorphic-git:mainfrom Oct 27, 2025
Merged
Conversation
fetsorn
changed the title
The doc string promises to reimplement default behaviour, and default header is called "Authorization", not "Authentication". User should expect this snippet to work exactly like the default onAuth. The next doc string about "X-Authentication" is fine since it's clearly an example of a custom header. docs: add @fetsorn as a contributor
Member
|
🎉 This PR is included in version 1.34.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doc string promises to reimplement default behaviour, and default header is called "Authorization", not "Authentication". User should expect this snippet to work exactly like the default onAuth.
The next doc string about "X-Authentication" is fine since it's clearly an example of a custom header.
I'm fixing a bug or typo
npm run add-contributorand follow the prompts to add yourself to the README